Skip to content

Conversation

mperrotti
Copy link
Contributor

Relates to https://github.com/github/primer/issues/2679

Screenshot 2023-11-21 at 2 48 44 PM

Changelog

New

The status prop now accepts 'unavailable'

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan

Testing & Reviewing

Merge checklist

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@mperrotti mperrotti requested review from a team and langermank November 21, 2023 19:58
Copy link

changeset-bot bot commented Nov 21, 2023

🦋 Changeset detected

Latest commit: 2a85556

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Uh oh! @mperrotti, the image you shared is missing helpful alt text. Check your pull request body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

Copy link
Contributor

github-actions bot commented Nov 21, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 104.54 KB (+0.15% 🔺)
dist/browser.umd.js 105.09 KB (+0.16% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-3963 November 21, 2023 20:03 Inactive
@mperrotti mperrotti added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 21, 2023
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 21, 2023
@primer primer bot temporarily deployed to github-pages November 21, 2023 20:52 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3963 November 21, 2023 20:53 Inactive
@pksjce
Copy link
Contributor

pksjce commented Nov 22, 2023

This looks good to me! But I could not find the design decisions for this status type in https://primer.style/ui-patterns/degraded-experiences

@mperrotti mperrotti requested a review from pksjce November 22, 2023 19:28
@github-actions github-actions bot temporarily deployed to storybook-preview-3963 November 22, 2023 23:14 Inactive
@mperrotti
Copy link
Contributor Author

@pksjce - I don't think it needs to repeated be on both pages.

@primer primer bot mentioned this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants