SelectPanel2: Clean up stories #3962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0afa927.
Contributor
size-limit report 📦
|
siddharthkp
temporarily deployed
to
github-pages
GitHub Actions
Inactive
siddharthkp
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
approved these changes
Nov 24, 2023
Member
broccolinisoup
left a comment
broccolinisoup
left a comment
There was a problem hiding this comment.
The stories are all looking good to me overall. Just left a question. Let me know if there is any specific feedback you are after in the stories!
| <SelectPanel | ||
| title="Select labels" | ||
| onSubmit={onSubmit} | ||
| onCancel={() => { |
Member
There was a problem hiding this comment.
Is this a good place to utilize storybook actions or is this story generic enough that we don't need actions?
I don't think I'm utilizing them as much, Josh brought it to my attention in one of the code reviews and I am curious what you think about them as well?
Member
Author
There was a problem hiding this comment.
I don't think I'm utilizing them as much
Same! I rarely think of them 😅
I've added them to the playground now. Let's see if they are useful
siddharthkp
temporarily deployed
to
github-pages
GitHub Actions
Inactive
siddharthkp
temporarily deployed
to
github-pages
GitHub Actions
Inactive
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.