-
Notifications
You must be signed in to change notification settings - Fork 637
Link: Add inline prop to tag links inside a text block #3946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 8bb69b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just had a comment for the story and also wanted to ask if this should be added to the Link.docs.json
as well for the site?
</Link> | ||
) | ||
|
||
export const Inline = () => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a good candidate for a dev story, similar to what we have for button (I think?). What would you think of having the example in the feature here be a link in a text block and this would be its own dev story?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, done!
From A more readable GitHub,
This PR implements the short term strategy from https://github.com/github/primer/discussions/2836#discussioncomment-7533878
Note: inline=true overrides underline=false and adds an underline
Story with all combinations: https://primer-091e4ade04-13348165.drafts.github.io/storybook/?path=/story/components-link-features--inline