Skip to content

Conversation

@strackoverflow
Copy link
Member

Closes #3716

This PR updates AvatarStack to show a border when there is only one avatar in the stack, making it consistent with the appearance of the Avatar component. This is especially obvious when using a high-contrast theme.

Before After
before (invisible border) after (visible border)

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan

Testing & Reviewing

Merge checklist

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@strackoverflow strackoverflow self-assigned this Nov 7, 2023
@strackoverflow strackoverflow requested review from a team and siddharthkp November 7, 2023 17:57
@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2023

🦋 Changeset detected

Latest commit: 8b09422

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 104.08 KB (+0.03% 🔺)
dist/browser.umd.js 104.64 KB (+0.03% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-3916 November 7, 2023 18:02 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3916 November 7, 2023 18:03 Inactive
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! Good solution 👍

@strackoverflow strackoverflow added this pull request to the merge queue Nov 8, 2023
Merged via the queue into main with commit c2f81b3 Nov 8, 2023
@strackoverflow strackoverflow deleted the avatarstack-border branch November 8, 2023 17:00
@primer primer bot mentioned this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avatar component has higher contrast than AvatarStack

3 participants