Fix MarkdownEditor fullHeight support #3893
Conversation
🦋 Changeset detectedLatest commit: b3ead6c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
stkao05
force-pushed
the
markdown-editor-fullheight
branch
from
5243680 to
1a97aea
Compare
stkao05
force-pushed
the
markdown-editor-fullheight
branch
from
1a97aea to
e425e2f
Compare
stkao05
force-pushed
the
markdown-editor-fullheight
branch
from
e425e2f to
3a64db0
Compare
.changeset/fluffy-months-invite.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
There was a problem hiding this comment.
There are 2 changesets here, I imagine you only want the patch one?
| <MarkdownEditor.Label visuallyHidden={hideLabel}>Markdown Editor Example</MarkdownEditor.Label> | ||
| </MarkdownEditor> | ||
| <p>Note: for demo purposes, files starting with "A" will be rejected.</p> | ||
| <div style={{height: '400px'}}> |
There was a problem hiding this comment.
🤔 what's the purpose of this height?
There was a problem hiding this comment.
I set the height of this element so we can test if the child MarkdownEditor component does extends to full height to its parent element height.
But I agree it is a bit confusing from the code. I can add comment or remove the change if you think it isn't needed.
There was a problem hiding this comment.
Remove the change for now.
stkao05
force-pushed
the
markdown-editor-fullheight
branch
2 times, most recently
from
c90be57 to
a268f5b
Compare
stkao05
force-pushed
the
markdown-editor-fullheight
branch
from
a268f5b to
ed1daaf
Compare
|
Thanks for reviewing. Just update the PR accordingly. |
siddharthkp
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
@stkao05, There are some recent changes to MarkdownEditor in |
stkao05
force-pushed
the
markdown-editor-fullheight
branch
from
bab7615 to
ed1daaf
Compare
no problem. just did 👌 |
2 participants
Closes #
Changelog
Changed
Currently, the MarkdownEditor's fullHeight prop doesn't take effect because the height change isn't applied to the outermost container element (
<fieldset>). The PR fixes the issue by applying full height style to the the container element.Storybook has also been updated for demo purpose.
(Demo screen recording: after the fix, the MarkdownEditor correctly resizes to full height when fullHeight is turned on)
Screen.Recording.2023-11-01.at.4.51.37.PM.mov
Rollout strategy
Testing & Reviewing
Merge checklist