Skip to content

ActionList: Checkbox inside disabled item should have not-allowed cusor #3870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 1, 2023
Merged

ActionList: Checkbox inside disabled item should have not-allowed cusor #3870

merged 8 commits into from
Nov 1, 2023

Conversation

@siddharthkp
Copy link
Member

Before After
Before: cursor hand on checkbox Before: cursor not-allowed on checkbox

@siddharthkp siddharthkp self-assigned this Oct 27, 2023
@siddharthkp siddharthkp requested a review from a team October 27, 2023 15:01
@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: ee801bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@siddharthkp siddharthkp added the patch release bug fixes, docs, housekeeping label Oct 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 103.55 KB (+0.01% 🔺)
dist/browser.umd.js 104.13 KB (+0.01% 🔺)

@siddharthkp siddharthkp temporarily deployed to github-pages October 27, 2023 15:08 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3870 October 27, 2023 15:09 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3870 October 27, 2023 15:09 Inactive
@siddharthkp siddharthkp added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 27, 2023
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 27, 2023
@primer primer bot temporarily deployed to github-pages October 27, 2023 15:27 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3870 October 27, 2023 15:27 Inactive
@siddharthkp siddharthkp temporarily deployed to github-pages October 27, 2023 15:51 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3870 October 27, 2023 15:52 Inactive
@siddharthkp siddharthkp temporarily deployed to github-pages October 30, 2023 14:54 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3870 October 30, 2023 14:54 Inactive
@siddharthkp
Copy link
Member Author

siddharthkp commented Oct 31, 2023 •
edited
Loading

Holding this PR off until after v36, changing to drafts for now

Update: v36 is merged! Onwards!

@siddharthkp siddharthkp marked this pull request as draft October 31, 2023 11:50
@siddharthkp siddharthkp marked this pull request as ready for review November 1, 2023 12:38
@siddharthkp siddharthkp enabled auto-merge November 1, 2023 12:38
@siddharthkp siddharthkp temporarily deployed to github-pages November 1, 2023 12:50 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3870 November 1, 2023 12:51 Inactive
@siddharthkp siddharthkp temporarily deployed to github-pages November 1, 2023 13:17 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3870 November 1, 2023 13:17 Inactive
@siddharthkp siddharthkp added this pull request to the merge queue Nov 1, 2023
Merged via the queue into main with commit 2c24d6a Nov 1, 2023
@siddharthkp siddharthkp deleted the actionlist-disabled-checkbox-cursor branch November 1, 2023 13:40
@primer primer bot mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pksjce pksjce pksjce approved these changes

@langermank langermank langermank approved these changes

Assignees

@siddharthkp siddharthkp

Labels

patch release bug fixes, docs, housekeeping

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@siddharthkp @pksjce @langermank