Skip to content

Delete changeset/changelog for change in story file #3857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2023
Merged

Delete changeset/changelog for change in story file #3857

merged 1 commit into from
Oct 24, 2023

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Oct 24, 2023 •
edited
Loading

Introduced in #3636, we usually don't add changelog for storybook files because it might mislead developers reading the changelog.

For example, from release tracking:

@primer/[email protected]

Patch Changes
- #3636 Thanks (author) - SelectPanel anchors should have aria-haspopup="dialog"

This looks like SelectPanel anchors will render aria-haspopup=dialog, which sounds totally finebut we updated an example in storybook, not the component.

Removing the changelog to avoid confusion.

@siddharthkp siddharthkp self-assigned this Oct 24, 2023
@siddharthkp siddharthkp requested a review from a team October 24, 2023 10:01
@changeset-bot

This comment was marked as resolved.

Sign in to view
@siddharthkp siddharthkp changed the title Delete changelog for story file Delete changeset/changelog for storyb file Oct 24, 2023
@siddharthkp siddharthkp changed the title Delete changeset/changelog for storyb file Delete changeset/changelog for story file Oct 24, 2023
@siddharthkp siddharthkp changed the title Delete changeset/changelog for story file Delete changeset/changelog for change in story file Oct 24, 2023
@siddharthkp siddharthkp added the skip changeset This change does not need a changelog label Oct 24, 2023
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/browser.esm.js 104.62 KB (0%)
dist/browser.umd.js 105.2 KB (0%)

@siddharthkp siddharthkp added this pull request to the merge queue Oct 24, 2023
Merged via the queue into main with commit add9689 Oct 24, 2023
@siddharthkp siddharthkp deleted the rm-stories-changelog branch October 24, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pksjce pksjce pksjce approved these changes

@joshblack joshblack joshblack approved these changes

Assignees

@siddharthkp siddharthkp

Labels

skip changeset This change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@siddharthkp @pksjce @joshblack @Copilot