-
Notifications
You must be signed in to change notification settings - Fork 645
refactor Dialog to use <dialog> internally #3840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 51c8194 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
e90fb09 to
92a5e9c
Compare
92a5e9c to
1f2d335
Compare
1f2d335 to
4ec1f2b
Compare
size-limit report 📦
|
4ec1f2b to
b12480d
Compare
b12480d to
54820e7
Compare
54820e7 to
2e21933
Compare
2e21933 to
fbe8372
Compare
ca66c14 to
85cbf4a
Compare
46179aa to
a9e6040
Compare
b5151ba to
a5033c6
Compare
a5033c6 to
b9b78be
Compare
b9b78be to
5dda5eb
Compare
5dda5eb to
51c8194
Compare
|
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days. |
|
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days. |
Refs https://github.com/github/primer/issues/2531
This changes
Dialogto use the<dialog>element internally, which allows us to delete a fair amount of code and should resolve some bugs and complexity we have with the current dialog.Changelog
New
Changed
Dialognow uses native<dialog>under the hood.Removed
Rollout strategy
Testing & Reviewing
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.