Skip to content

Update hover styles for ActionList item #3815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 16, 2023
Merged

Update hover styles for ActionList item #3815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
107b4fc
Update hover styles for ActionList item
pksjce Oct 13, 2023
e54b0af
Fix formatting
pksjce Oct 13, 2023
30f9691
Change the color
pksjce Oct 15, 2023
1bee44a
Create dry-zoos-love.md
pksjce Oct 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dry-zoos-love.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Update hover styles for ActionList item
1 change: 1 addition & 0 deletions src/ActionList/Item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ export const Item = React.forwardRef<HTMLLIElement, ActionListItemProps>(
':hover:not([aria-disabled])': {
backgroundColor: `actionListItem.${variant}.hoverBg`,
color: getVariantStyles(variant, disabled).hoverColor,
boxShadow: `inset 0 0 0 max(1px, 0.0625rem) ${theme?.colors.actionListItem.default.activeBorder}`,
},
'&:focus-visible, > a:focus-visible': {
outline: 'none',
Expand Down
8 changes: 8 additions & 0 deletions src/NavList/__snapshots__/NavList.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,7 @@ exports[`NavList renders a simple list 1`] = `
.c2:hover:not([aria-disabled]) {
background-color: rgba(208,215,222,0.32);
color: #1F2328;
box-shadow: inset 0 0 0 max(1px,0.0625rem) rgba(0,0,0,0);
}

.c2:focus-visible,
Expand All @@ -273,6 +274,7 @@ exports[`NavList renders a simple list 1`] = `
.c6:hover:not([aria-disabled]) {
background-color: rgba(208,215,222,0.32);
color: #1F2328;
box-shadow: inset 0 0 0 max(1px,0.0625rem) rgba(0,0,0,0);
}

.c6:focus-visible,
Expand Down Expand Up @@ -658,6 +660,7 @@ exports[`NavList renders with groups 1`] = `
.c6:hover:not([aria-disabled]) {
background-color: rgba(208,215,222,0.32);
color: #1F2328;
box-shadow: inset 0 0 0 max(1px,0.0625rem) rgba(0,0,0,0);
}

.c6:focus-visible,
Expand All @@ -683,6 +686,7 @@ exports[`NavList renders with groups 1`] = `
.c10:hover:not([aria-disabled]) {
background-color: rgba(208,215,222,0.32);
color: #1F2328;
box-shadow: inset 0 0 0 max(1px,0.0625rem) rgba(0,0,0,0);
}

.c10:focus-visible,
Expand Down Expand Up @@ -1145,6 +1149,7 @@ exports[`NavList.Item with NavList.SubNav does not have active styles if SubNav
.c10:hover:not([aria-disabled]) {
background-color: rgba(208,215,222,0.32);
color: #1F2328;
box-shadow: inset 0 0 0 max(1px,0.0625rem) rgba(0,0,0,0);
}

.c10:focus-visible,
Expand All @@ -1170,6 +1175,7 @@ exports[`NavList.Item with NavList.SubNav does not have active styles if SubNav
.c3:hover:not([aria-disabled]) {
background-color: rgba(208,215,222,0.32);
color: #1F2328;
box-shadow: inset 0 0 0 max(1px,0.0625rem) rgba(0,0,0,0);
}

.c3:focus-visible,
Expand Down Expand Up @@ -1627,6 +1633,7 @@ exports[`NavList.Item with NavList.SubNav has active styles if SubNav contains t
.c10:hover:not([aria-disabled]) {
background-color: rgba(208,215,222,0.32);
color: #1F2328;
box-shadow: inset 0 0 0 max(1px,0.0625rem) rgba(0,0,0,0);
}

.c10:focus-visible,
Expand All @@ -1652,6 +1659,7 @@ exports[`NavList.Item with NavList.SubNav has active styles if SubNav contains t
.c3:hover:not([aria-disabled]) {
background-color: rgba(208,215,222,0.32);
color: #1F2328;
box-shadow: inset 0 0 0 max(1px,0.0625rem) rgba(0,0,0,0);
}

.c3:focus-visible,
Expand Down