Skip to content

feat(ToggleSwitch): add support for a ref on the inner <button> element #3813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 16, 2023
Merged

feat(ToggleSwitch): add support for a ref on the inner <button> element #3813

merged 3 commits into from
Oct 16, 2023

Conversation

joshblack
Copy link
Member

Closes #3806

Changelog

New

Changed

  • ToggleSwitch now accepts a ref on the inner <button> element
  • Move ToggleSwitch test fixtures next to component

Removed

Rollout strategy

  • Minor release

Testing & Reviewing

  • Verify that ToggleSwitch supports ref
  • Verify that tests capture semantics of ref (specifically as a HTMLButtonElement)

@joshblack joshblack requested review from a team and josepmartins October 12, 2023 17:49
@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: a7903ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joshblack joshblack mentioned this pull request Oct 12, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 104.77 KB (-0.01% 🔽)
dist/browser.umd.js 105.36 KB (-0.01% 🔽)

@joshblack joshblack temporarily deployed to github-pages October 12, 2023 17:57 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3813 October 12, 2023 17:57 Inactive
siddharthkp
siddharthkp approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as a fix!

Optional feedback for a follow up PR: #3806 (comment)

@joshblack joshblack enabled auto-merge October 16, 2023 15:54
@joshblack joshblack added this pull request to the merge queue Oct 16, 2023
Merged via the queue into main with commit 1fcfc47 Oct 16, 2023
@joshblack joshblack deleted the 3806-add-ref-to-toggleswitch branch October 16, 2023 16:08
This was referenced Oct 16, 2023
Merged
Closed
@skemex skemex mentioned this pull request May 24, 2024
Open
@rbragaru rbragaru mentioned this pull request Aug 14, 2024
Open
@skemex skemex mentioned this pull request Sep 24, 2024
Open
@skemex skemex mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@broccolinisoup broccolinisoup broccolinisoup approved these changes

@siddharthkp siddharthkp siddharthkp approved these changes

@josepmartins josepmartins Awaiting requested review from josepmartins

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add ability to pass ref to ToggleSwitch

4 participants

@joshblack @broccolinisoup @siddharthkp @Copilot