Revert "Add aria-selected value to ActionList.Item." #3784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 66482a7.
🦋 Changeset detectedLatest commit: e96d863 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
|
@joshblack could you please give this a review when you have a moment and, if all looks good to you and tests pass, merge on behalf of |
joshblack
approved these changes
Oct 9, 2023
joshblack
deleted the
revert-3579-action-list-item-screen-reader-announce-state
branch
This was referenced Oct 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit
242c634.There was some disagreement about how ActionList items should announce if they're selected or not. There's a functional difference between an item being "selected" (the user is currently focused on it) and "checked" (the option was previously chosen and is active). We want to communicate the former, but the
aria-selectedattribute is the incorrect way to do this.This should not impact anything major in dotcom, as both changes were internal to the component, and did not require any changes by consumers.