Skip to content

feat(npm): export components deprecated in v36 from @primer/react/deprecated #3719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2023
Merged

feat(npm): export components deprecated in v36 from @primer/react/deprecated #3719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a9900f
feat: move deprecated components in v36 to deprecated
joshblack Sep 7, 2023
0018024
chore: add changeset
joshblack Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/tough-pillows-glow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@primer/react': minor
---

The UnderlineNav, FilterList, and FilteredSearch components will be deprecated in v36 and have been moved to the deprecated entrypoint. To use the new UnderlineNav, migrate to the component available in drafts.

<!-- Changed components: FilterList, FilteredSearch, UnderlineNav -->
3 changes: 3 additions & 0 deletions src/__tests__/__snapshots__/exports.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@ exports[`@primer/react/decprecated should not update exports without a semver ch
"Dropdown",
"DropdownButton",
"DropdownMenu",
"FilterList",
"FilteredSearch",
"Fixed",
"Flex",
"FormGroup",
Expand All @@ -128,6 +130,7 @@ exports[`@primer/react/decprecated should not update exports without a semver ch
"Relative",
"SelectMenu",
"Sticky",
"UnderlineNav",
]
`;

Expand Down
8 changes: 8 additions & 0 deletions src/deprecated/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,3 +72,11 @@ export type {
ButtonCloseProps,
} from './Button'
// end of v35.0.0

// Deprecated in v36
export {default as FilterList} from '../FilterList'
export type {FilterListProps, FilterListItemProps} from '../FilterList'
export {default as FilteredSearch} from '../FilteredSearch'
export type {FilteredSearchProps} from '../FilteredSearch'
export {default as UnderlineNav} from '../UnderlineNav'
export type {UnderlineNavProps, UnderlineNavLinkProps} from '../UnderlineNav'