Use control CSS var with fallback for form component border-color
#3654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2c7f21b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
joshblack
approved these changes
Aug 22, 2023
langermank
had a problem deploying
to
github-pages
GitHub Actions
Failure
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
added
update snapshots
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
removed
the
update snapshots
langermank
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
added
the
update snapshots
github-actions
bot
removed
the
update snapshots
This was referenced Aug 28, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dotcom, we're running a test that will gradually increase the contrast of form component borders. This PR introduces the
controlCSS variable used to set the color, and leaves the existing JS in place as a fallback. There will be no visual changes in the Primer React library during this process.Part of https://github.com/github/primer/issues/836
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.