[⏪ Reverted] Show underline on Link when hovered or focused.

[radglob]

Resolves https://github.com/github/accessibility-audits/issues/4502 (and likely other issues).

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

• Added/updated tests
• Added/updated documentation
• Changes are SSR compatible
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

[changeset-bot]

🦋 Changeset detected

Latest commit: 0e3edf6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/browser.esm.js	103.68 KB (+0.03% 🔺)
dist/browser.umd.js	104.22 KB (+0.01% 🔺)

[lesliecdubs]

👋🏻 Let's aim to get a Primer Design reviewer to give this a thorough review before merging, as it will have a noticeable impact on the visual styles across a wide area of the product. @langermank would you be willing to give this 👀 s since I know you've worked on Link before?

[langermank]

I think this change makes sense! The only thing that stands out to me is that we list it as a common mistake in our interface guidelines. But we don't really follow those guidelines for links across GitHub anyhow, and I think this change is still an improvement?