Skip to content

ActionList: Fix icon and description hover color for danger variant #3505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 12, 2023
Merged

ActionList: Fix icon and description hover color for danger variant #3505

merged 11 commits into from
Jul 12, 2023

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Jul 10, 2023 •
edited
Loading

@siddharthkp siddharthkp requested a review from a team July 10, 2023 10:55
@siddharthkp siddharthkp self-assigned this Jul 10, 2023
@siddharthkp siddharthkp requested a review from josepmartins July 10, 2023 10:55
@changeset-bot
Copy link

changeset-bot bot commented Jul 10, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 4068169

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

This comment was marked as resolved.

Sign in to view
@siddharthkp siddharthkp added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 10, 2023
@siddharthkp siddharthkp requested review from joshblack and removed request for josepmartins July 10, 2023 10:58
@siddharthkp siddharthkp mentioned this pull request Jul 10, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 102.37 KB (+0.06% 🔺)
dist/browser.umd.js 102.92 KB (+0.05% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-3505 July 10, 2023 11:03 Inactive
@siddharthkp siddharthkp temporarily deployed to github-pages July 10, 2023 11:03 — with GitHub Actions Inactive
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 10, 2023
@github-actions github-actions bot temporarily deployed to storybook-preview-3505 July 10, 2023 11:05 Inactive
@siddharthkp siddharthkp changed the base branch from main to fixtures-3044 July 10, 2023 11:09
@primer primer bot temporarily deployed to github-pages July 10, 2023 11:09 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3505 July 10, 2023 11:10 Inactive
Base automatically changed from fixtures-3044 to main July 10, 2023 15:54
@siddharthkp siddharthkp added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 11, 2023
@siddharthkp siddharthkp temporarily deployed to github-pages July 11, 2023 14:58 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3505 July 11, 2023 14:59 Inactive
@siddharthkp siddharthkp added update snapshots 🤖 Command that updates VRT snapshots on the pull request and removed update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Jul 11, 2023
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 11, 2023
siddharthkp
siddharthkp commented Jul 12, 2023
View reviewed changes
Copy link
Member Author

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see a clean diff :feels-good:

@siddharthkp siddharthkp added this pull request to the merge queue Jul 12, 2023
Merged via the queue into main with commit c3f1e3c Jul 12, 2023
@siddharthkp siddharthkp deleted the fixes-3044 branch July 12, 2023 09:48
This was referenced Jul 12, 2023
Merged
Closed
@siddharthkp siddharthkp mentioned this pull request Nov 1, 2023
Closed
@skemex skemex mentioned this pull request May 24, 2024
Open
@rbragaru rbragaru mentioned this pull request Aug 14, 2024
Open
@skemex skemex mentioned this pull request Sep 24, 2024
Open
@skemex skemex mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshblack joshblack joshblack approved these changes

@langermank langermank langermank approved these changes

Assignees

@siddharthkp siddharthkp

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@siddharthkp @joshblack @langermank @Copilot