Skip to content

Revert "Address ToggleSwitch a11y feedback, take 2" #3483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 4, 2023
Merged

Revert "Address ToggleSwitch a11y feedback, take 2" #3483

merged 2 commits into from
Jul 4, 2023

Conversation

siddharthkp
Copy link
Member

Reverts #3433

My bad! I merged too soon, Ref: #3433 (comment)

@siddharthkp siddharthkp requested review from a team and josepmartins July 4, 2023 12:24
@changeset-bot

This comment was marked as outdated.

Sign in to view
@siddharthkp siddharthkp self-assigned this Jul 4, 2023
@siddharthkp siddharthkp removed the request for review from josepmartins July 4, 2023 12:24
@siddharthkp siddharthkp mentioned this pull request Jul 4, 2023
Merged
6 tasks
@siddharthkp siddharthkp added the skip changeset This change does not need a changelog label Jul 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 101.82 KB (+0.02% 🔺)
dist/browser.umd.js 102.37 KB (+0.02% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-3483 July 4, 2023 12:29 Inactive
broccolinisoup
broccolinisoup approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@broccolinisoup broccolinisoup added this pull request to the merge queue Jul 4, 2023
Merged via the queue into main with commit 7d08d28 Jul 4, 2023
@broccolinisoup broccolinisoup deleted the revert-3433-toggle_switch_a11y_take2 branch July 4, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@broccolinisoup broccolinisoup broccolinisoup approved these changes

Assignees

@siddharthkp siddharthkp

Labels

skip changeset This change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@siddharthkp @broccolinisoup @Copilot