Skip to content

Conversation

broccolinisoup
Copy link
Member

@broccolinisoup broccolinisoup commented Jun 23, 2023

The icons on UnderlineNav should be muted to match the current implementation and the rest of the website. reference (GitHub stuff only)

Screenshots

Before

Light
An example with 5 nav items of the GitHub main navigation on a light mode with icons have muted black color
Dark Dimmed
An example with 5 nav items of the GitHub main navigation on a dark dimmed mode with icons have  brighter and high contrast gray color

After

Light
An example with 5 nav items of the GitHub main navigation on a light mode with icons have high contrast black color
Dark Dimmed
An example with 5 nav items of the GitHub main navigation on a dark dimmed mode with icons have  muted gray color

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@broccolinisoup broccolinisoup requested review from a team and joshblack June 23, 2023 02:07
@changeset-bot
Copy link

changeset-bot bot commented Jun 23, 2023

🦋 Changeset detected

Latest commit: 31d3e0c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 23, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 101.95 KB (+0.02% 🔺)
dist/browser.umd.js 102.5 KB (+0.01% 🔺)

@broccolinisoup broccolinisoup temporarily deployed to github-pages June 23, 2023 02:12 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3446 June 23, 2023 02:12 Inactive
@broccolinisoup broccolinisoup temporarily deployed to github-pages June 23, 2023 02:21 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3446 June 23, 2023 02:22 Inactive
@broccolinisoup broccolinisoup added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants