Skip to content

3230 Refactor internal components - TextInputInnerAction #3372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 5, 2023
Merged

3230 Refactor internal components - TextInputInnerAction #3372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
230a2fc
refactor(TextInputInnerAction): moved to internal
agreenberry Jun 5, 2023
3a83e69
Merge branch 'main' into 3230-refactor-internal-components-TextInputI…
agreenberry Jun 6, 2023
0ba8093
Merge branch 'main' into 3230-refactor-internal-components-TextInputI…
agreenberry Jun 6, 2023
4317590
Merge branch 'main' into 3230-refactor-internal-components-TextInputI…
agreenberry Jun 7, 2023
0dab324
Merge branch 'main' into 3230-refactor-internal-components-TextInputI…
agreenberry Jun 8, 2023
5a23a67
update snapshot
agreenberry Jun 8, 2023
86c215d
Merge branch 'main' into 3230-refactor-internal-components-TextInputI…
agreenberry Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/TextInput/TextInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import TextInputInnerVisualSlot from '../internal/components/TextInputInnerVisua
import {useProvidedRefOrCreate} from '../hooks'
import {Merge} from '../utils/types'
import TextInputWrapper, {StyledWrapperProps} from '../internal/components/TextInputWrapper'
import TextInputAction from '../internal/components/TextInputInnerAction'
import UnstyledTextInput from '../internal/components/UnstyledTextInput'
import TextInputAction from '../_TextInputInnerAction'

export type TextInputNonPassthroughProps = {
/** @deprecated Use `leadingVisual` or `trailingVisual` prop instead */
Expand Down
56 changes: 28 additions & 28 deletions src/__tests__/__snapshots__/TextInput.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1557,20 +1557,6 @@ exports[`TextInput renders trailingAction icon button 1`] = `
padding-right: 0;
}

.c1 {
border: 0;
font-size: inherit;
font-family: inherit;
background-color: transparent;
-webkit-appearance: none;
color: inherit;
width: 100%;
}

.c1:focus {
outline: 0;
}

.c3 {
position: relative;
}
Expand Down Expand Up @@ -1795,6 +1781,20 @@ exports[`TextInput renders trailingAction icon button 1`] = `
left: 10px;
}

.c1 {
border: 0;
font-size: inherit;
font-family: inherit;
background-color: transparent;
-webkit-appearance: none;
color: inherit;
width: 100%;
}

.c1:focus {
outline: 0;
}

@media (forced-colors:active) {
.c4:focus {
outline: solid 1px transparent;
Expand Down Expand Up @@ -2608,20 +2608,6 @@ exports[`TextInput renders trailingAction text button with a tooltip 1`] = `
padding-right: 0;
}

.c1 {
border: 0;
font-size: inherit;
font-family: inherit;
background-color: transparent;
-webkit-appearance: none;
color: inherit;
width: 100%;
}

.c1:focus {
outline: 0;
}

.c3 {
position: relative;
display: inline-block;
Expand Down Expand Up @@ -2847,6 +2833,20 @@ exports[`TextInput renders trailingAction text button with a tooltip 1`] = `
left: 10px;
}

.c1 {
border: 0;
font-size: inherit;
font-family: inherit;
background-color: transparent;
-webkit-appearance: none;
color: inherit;
width: 100%;
}

.c1:focus {
outline: 0;
}

@media (forced-colors:active) {
.c4:focus {
outline: solid 1px transparent;
Expand Down
8 changes: 4 additions & 4 deletions src/_TextInputInnerAction.tsx → ...ernal/components/TextInputInnerAction.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import React, {forwardRef} from 'react'
import {IconProps} from '@primer/octicons-react'
import Box from './Box'
import {Button, IconButton, ButtonProps} from './Button'
import Tooltip from './Tooltip'
import {BetterSystemStyleObject, merge, SxProp} from './sx'
import Box from '../../Box'
import {Button, IconButton, ButtonProps} from '../../Button'
import Tooltip from '../../Tooltip'
import {BetterSystemStyleObject, merge, SxProp} from '../../sx'

type TextInputActionProps = Omit<
React.ButtonHTMLAttributes<HTMLButtonElement>,
Expand Down