-
Notifications
You must be signed in to change notification settings - Fork 639
[docs only] Add octicons-react import to Octicon docs example #3301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋🏻 @tomthorogood, sorry to hear about your experience! Great idea to add the import paths, thanks so much for that 🙏🏻
@broccolinisoup do you have any advice on how to correct the |
👋🏻 @tomthorogood If you could run Re the changeset, I added |
@tomthorogood I see in the diff there are version changes on the |
@broccolinisoup I assumed that was expected from running the format script; I didn't intend it, though. |
@tomthorogood Interesting, as far as I know format running shouldn't cause a package-lock changes. Could you try removing it from the diff and make sure only the mdx changes come through? Thank you 🙏🏻 |
When reading through the
StyledOcticon
docs, I had a hard time figuring out where to import the*Icon
s from, and had to grep the primer/react code base for bit before I found it. I figured this would help others from having to do the same.Merge checklist
[ ] Added/updated tests[ ] Changes are SSR compatible[ ] Tested in Chrome[ ] Tested in Firefox[ ] Tested in Safari[ ] Tested in EdgeTake a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.