Skip to content

Remove --primer prefix from CSS var #3209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 21, 2023
Merged

Remove --primer prefix from CSS var #3209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6bcda0b
update new name
langermank Apr 21, 2023
9bf6674
Create late-hotels-turn.md
langermank Apr 21, 2023
1ee99f7
snaps
langermank Apr 21, 2023
c145ae0
Merge branch 'css-var-update' of https://github.com/primer/react into…
langermank Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/late-hotels-turn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Remove `--primer` prefix from CSS var
2 changes: 1 addition & 1 deletion src/Radio/Radio.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export type RadioProps = {

const StyledRadio = styled.input`
${sharedCheckboxAndRadioStyles};
border-radius: var(--primer-borderRadius-full, 100vh);
border-radius: var(--borderRadius-full, 100vh);
transition: background-color, border-color 80ms cubic-bezier(0.33, 1, 0.68, 1); /* checked -> unchecked - add 120ms delay to fully see animation-out */

&:checked {
Expand Down
2 changes: 1 addition & 1 deletion src/__tests__/__snapshots__/CheckboxOrRadioGroup.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ exports[`CheckboxOrRadioGroup renders consistently 1`] = `
place-content: center;
position: relative;
width: var(--base-size-16,16px);
border-radius: var(--primer-borderRadius-full,100vh);
border-radius: var(--borderRadius-full,100vh);
-webkit-transition: background-color,border-color 80ms cubic-bezier(0.33,1,0.68,1);
transition: background-color,border-color 80ms cubic-bezier(0.33,1,0.68,1);
}
Expand Down
2 changes: 1 addition & 1 deletion src/__tests__/__snapshots__/Radio.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ exports[`Radio renders consistently 1`] = `
place-content: center;
position: relative;
width: var(--base-size-16,16px);
border-radius: var(--primer-borderRadius-full,100vh);
border-radius: var(--borderRadius-full,100vh);
-webkit-transition: background-color,border-color 80ms cubic-bezier(0.33,1,0.68,1);
transition: background-color,border-color 80ms cubic-bezier(0.33,1,0.68,1);
}
Expand Down
2 changes: 1 addition & 1 deletion src/__tests__/__snapshots__/RadioGroup.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ exports[`RadioGroup renders consistently 1`] = `
place-content: center;
position: relative;
width: var(--base-size-16,16px);
border-radius: var(--primer-borderRadius-full,100vh);
border-radius: var(--borderRadius-full,100vh);
-webkit-transition: background-color,border-color 80ms cubic-bezier(0.33,1,0.68,1);
transition: background-color,border-color 80ms cubic-bezier(0.33,1,0.68,1);
}
Expand Down
18 changes: 9 additions & 9 deletions src/__tests__/deprecated/__snapshots__/ChoiceFieldset.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ exports[`ChoiceFieldset renders a disabled list 1`] = `
place-content: center;
position: relative;
width: var(--base-size-16,16px);
border-radius: var(--primer-borderRadius-full,100vh);
border-radius: var(--borderRadius-full,100vh);
-webkit-transition: background-color,border-color 80ms cubic-bezier(0.33,1,0.68,1);
transition: background-color,border-color 80ms cubic-bezier(0.33,1,0.68,1);
}
Expand Down Expand Up @@ -288,7 +288,7 @@ exports[`ChoiceFieldset renders a fieldset with a description 1`] = `
place-content: center;
position: relative;
width: var(--base-size-16,16px);
border-radius: var(--primer-borderRadius-full,100vh);
border-radius: var(--borderRadius-full,100vh);
-webkit-transition: background-color,border-color 80ms cubic-bezier(0.33,1,0.68,1);
transition: background-color,border-color 80ms cubic-bezier(0.33,1,0.68,1);
}
Expand Down Expand Up @@ -531,7 +531,7 @@ exports[`ChoiceFieldset renders a list of items with leading visuals and caption
place-content: center;
position: relative;
width: var(--base-size-16,16px);
border-radius: var(--primer-borderRadius-full,100vh);
border-radius: var(--borderRadius-full,100vh);
-webkit-transition: background-color,border-color 80ms cubic-bezier(0.33,1,0.68,1);
transition: background-color,border-color 80ms cubic-bezier(0.33,1,0.68,1);
}
Expand Down Expand Up @@ -1132,7 +1132,7 @@ exports[`ChoiceFieldset renders a required fieldset 1`] = `
place-content: center;
position: relative;
width: var(--base-size-16,16px);
border-radius: var(--primer-borderRadius-full,100vh);
border-radius: var(--borderRadius-full,100vh);
-webkit-transition: background-color,border-color 80ms cubic-bezier(0.33,1,0.68,1);
transition: background-color,border-color 80ms cubic-bezier(0.33,1,0.68,1);
}
Expand Down Expand Up @@ -1360,7 +1360,7 @@ exports[`ChoiceFieldset renders default 1`] = `
place-content: center;
position: relative;
width: var(--base-size-16,16px);
border-radius: var(--primer-borderRadius-full,100vh);
border-radius: var(--borderRadius-full,100vh);
-webkit-transition: background-color,border-color 80ms cubic-bezier(0.33,1,0.68,1);
transition: background-color,border-color 80ms cubic-bezier(0.33,1,0.68,1);
}
Expand Down Expand Up @@ -1575,7 +1575,7 @@ exports[`ChoiceFieldset renders with a custom name and id passed 1`] = `
place-content: center;
position: relative;
width: var(--base-size-16,16px);
border-radius: var(--primer-borderRadius-full,100vh);
border-radius: var(--borderRadius-full,100vh);
-webkit-transition: background-color,border-color 80ms cubic-bezier(0.33,1,0.68,1);
transition: background-color,border-color 80ms cubic-bezier(0.33,1,0.68,1);
}
Expand Down Expand Up @@ -1794,7 +1794,7 @@ exports[`ChoiceFieldset renders with a hidden legend 1`] = `
place-content: center;
position: relative;
width: var(--base-size-16,16px);
border-radius: var(--primer-borderRadius-full,100vh);
border-radius: var(--borderRadius-full,100vh);
-webkit-transition: background-color,border-color 80ms cubic-bezier(0.33,1,0.68,1);
transition: background-color,border-color 80ms cubic-bezier(0.33,1,0.68,1);
}
Expand Down Expand Up @@ -2050,7 +2050,7 @@ exports[`ChoiceFieldset renders with a success validation message 1`] = `
place-content: center;
position: relative;
width: var(--base-size-16,16px);
border-radius: var(--primer-borderRadius-full,100vh);
border-radius: var(--borderRadius-full,100vh);
-webkit-transition: background-color,border-color 80ms cubic-bezier(0.33,1,0.68,1);
transition: background-color,border-color 80ms cubic-bezier(0.33,1,0.68,1);
}
Expand Down Expand Up @@ -2344,7 +2344,7 @@ exports[`ChoiceFieldset renders with an error validation message 1`] = `
place-content: center;
position: relative;
width: var(--base-size-16,16px);
border-radius: var(--primer-borderRadius-full,100vh);
border-radius: var(--borderRadius-full,100vh);
-webkit-transition: background-color,border-color 80ms cubic-bezier(0.33,1,0.68,1);
transition: background-color,border-color 80ms cubic-bezier(0.33,1,0.68,1);
}
Expand Down