Skip to content

Deprecate legacy slots implementation #3205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2023
Merged

Deprecate legacy slots implementation #3205

merged 2 commits into from
Apr 24, 2023

Conversation

colebemis
Copy link
Contributor

@colebemis colebemis commented Apr 21, 2023 •
edited
Loading

Deprecates the internal createSlots util (not SSR-compatible) in favor of the SSR-friendly useSlots hook

Closes #1690

@colebemis colebemis requested review from a team and siddharthkp April 21, 2023 15:24
@changeset-bot
Copy link

changeset-bot bot commented Apr 21, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 08f0705

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@colebemis colebemis added the skip changeset This change does not need a changelog label Apr 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 95.37 KB (0%)
dist/browser.umd.js 95.91 KB (0%)

@colebemis colebemis mentioned this pull request Apr 21, 2023
Closed
10 tasks
@colebemis colebemis temporarily deployed to github-pages April 21, 2023 15:30 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3205 April 21, 2023 15:31 Inactive
@colebemis colebemis added this pull request to the merge queue Apr 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 21, 2023
@colebemis colebemis added this pull request to the merge queue Apr 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 22, 2023
@colebemis colebemis merged commit cb233cf into main Apr 24, 2023
@colebemis colebemis deleted the remove-legacy-slots branch April 24, 2023 20:15
@jonrohan jonrohan mentioned this pull request Apr 24, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mperrotti mperrotti mperrotti approved these changes

@joshblack joshblack joshblack approved these changes

@siddharthkp siddharthkp Awaiting requested review from siddharthkp

Assignees

No one assigned

Labels

skip changeset This change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Batch] Improve slots implementation in PRC to enable React SSR compatibility & performance gain

3 participants

@colebemis @mperrotti @joshblack