Skip to content

3096 remove aria live=polite on textinput wrapper #3182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 27, 2023
Merged

3096 remove aria live=polite on textinput wrapper #3182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f1d89ac
Fix create-slots utils path
jonrohan Apr 24, 2023
ba71bf1
fix(TextInput): changed aria-live polite
agreenberry Apr 24, 2023
1e7d241
chore: added changeset
agreenberry Apr 24, 2023
b574b4c
Merge remote-tracking branch 'origin/fix_slot_import_path' into 3096-…
agreenberry Apr 24, 2023
cfeccea
Merge remote-tracking branch 'origin/main' into 3096-remove-aria-live…
agreenberry Apr 25, 2023
94bfdad
chore(Autocomplete): update snapshot
agreenberry Apr 25, 2023
e0df017
Merge branch 'main' into 3096-remove-aria-live=polite-on-textinput-wr…
agreenberry Apr 25, 2023
eedb6e4
chore(TextInput): update snapshot
agreenberry Apr 25, 2023
b14a34a
Merge branch '3096-remove-aria-live=polite-on-textinput-wrapper' of g…
agreenberry Apr 25, 2023
b894e21
update snpahots
agreenberry Apr 25, 2023
048bad2
update again
agreenberry Apr 25, 2023
8e6ef01
Merge branch 'main' into 3096-remove-aria-live=polite-on-textinput-wr…
agreenberry Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/swift-cobras-visit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Removed default aria-live polite
1 change: 0 additions & 1 deletion src/TextInput/TextInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ const TextInput = React.forwardRef<HTMLInputElement, TextInputProps>(
hasTrailingAction={Boolean(trailingAction)}
isInputFocused={isInputFocused}
onClick={focusInput}
aria-live="polite"
aria-busy={Boolean(loading)}
>
{IconComponent && <IconComponent className="TextInput-icon" />}
Expand Down
1 change: 1 addition & 0 deletions src/_InputValidation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ const InputValidation: React.FC<React.PropsWithChildren<Props>> = ({children, id
},
...sx,
}}
aria-live="polite"
>
{IconComponent && (
<Box as="span" mr={1} sx={{display: 'flex'}} aria-hidden="true">
Expand Down
7 changes: 0 additions & 7 deletions src/__tests__/__snapshots__/Autocomplete.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@ exports[`snapshots renders a custom empty state message 1`] = `

<span
aria-busy={false}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down Expand Up @@ -265,7 +264,6 @@ exports[`snapshots renders a loading state 1`] = `

<span
aria-busy={false}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down Expand Up @@ -460,7 +458,6 @@ exports[`snapshots renders a menu that contains an item to add to the menu 1`] =

<span
aria-busy={false}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down Expand Up @@ -1418,7 +1415,6 @@ exports[`snapshots renders a multiselect input 1`] = `

<span
aria-busy={false}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down Expand Up @@ -2286,7 +2282,6 @@ exports[`snapshots renders a multiselect input with selected menu items 1`] = `

<span
aria-busy={false}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down Expand Up @@ -3165,7 +3160,6 @@ exports[`snapshots renders a single select input 1`] = `

<span
aria-busy={false}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down Expand Up @@ -4174,7 +4168,6 @@ exports[`snapshots renders with an input value 1`] = `

<span
aria-busy={false}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down
28 changes: 0 additions & 28 deletions src/__tests__/__snapshots__/TextInput.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ exports[`TextInput renders 1`] = `

<span
aria-busy={false}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down Expand Up @@ -231,7 +230,6 @@ exports[`TextInput renders block 1`] = `

<span
aria-busy={false}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down Expand Up @@ -350,7 +348,6 @@ exports[`TextInput renders consistently 1`] = `

<span
aria-busy={false}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down Expand Up @@ -469,7 +466,6 @@ exports[`TextInput renders contrast 1`] = `

<span
aria-busy={false}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down Expand Up @@ -595,7 +591,6 @@ exports[`TextInput renders error 1`] = `

<span
aria-busy={false}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down Expand Up @@ -720,7 +715,6 @@ exports[`TextInput renders large 1`] = `

<span
aria-busy={false}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
size="large"
Expand Down Expand Up @@ -840,7 +834,6 @@ exports[`TextInput renders leadingVisual 1`] = `

<span
aria-busy={false}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down Expand Up @@ -987,7 +980,6 @@ exports[`TextInput renders monospace 1`] = `

<span
aria-busy={false}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down Expand Up @@ -1106,7 +1098,6 @@ exports[`TextInput renders placeholder 1`] = `

<span
aria-busy={false}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down Expand Up @@ -1234,7 +1225,6 @@ exports[`TextInput renders small 1`] = `

<span
aria-busy={false}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
size="small"
Expand Down Expand Up @@ -1831,7 +1821,6 @@ exports[`TextInput renders trailingAction icon button 1`] = `

<span
aria-busy={false}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down Expand Up @@ -2254,7 +2243,6 @@ exports[`TextInput renders trailingAction text button 1`] = `

<span
aria-busy={false}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down Expand Up @@ -2881,7 +2869,6 @@ exports[`TextInput renders trailingAction text button with a tooltip 1`] = `

<span
aria-busy={false}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down Expand Up @@ -3029,7 +3016,6 @@ exports[`TextInput renders trailingVisual 1`] = `

<span
aria-busy={false}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down Expand Up @@ -3182,7 +3168,6 @@ exports[`TextInput renders warning 1`] = `

<span
aria-busy={false}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down Expand Up @@ -3316,7 +3301,6 @@ exports[`TextInput renders with a loading indicator 1`] = `

<span
aria-busy={true}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down Expand Up @@ -3489,7 +3473,6 @@ exports[`TextInput renders with a loading indicator 1`] = `

<span
aria-busy={true}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down Expand Up @@ -3694,7 +3677,6 @@ exports[`TextInput renders with a loading indicator 1`] = `

<span
aria-busy={true}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down Expand Up @@ -3876,7 +3858,6 @@ exports[`TextInput renders with a loading indicator 1`] = `

<span
aria-busy={true}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down Expand Up @@ -4127,7 +4108,6 @@ exports[`TextInput renders with a loading indicator 1`] = `

<span
aria-busy={true}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down Expand Up @@ -4378,7 +4358,6 @@ exports[`TextInput renders with a loading indicator 1`] = `

<span
aria-busy={true}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down Expand Up @@ -4623,7 +4602,6 @@ exports[`TextInput renders with a loading indicator 1`] = `

<span
aria-busy={true}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down Expand Up @@ -4836,7 +4814,6 @@ exports[`TextInput renders with a loading indicator 1`] = `

<span
aria-busy={true}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down Expand Up @@ -5081,7 +5058,6 @@ exports[`TextInput renders with a loading indicator 1`] = `

<span
aria-busy={true}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down Expand Up @@ -5311,7 +5287,6 @@ exports[`TextInput renders with a loading indicator 1`] = `

<span
aria-busy={true}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
size="small"
Expand Down Expand Up @@ -5603,7 +5578,6 @@ exports[`TextInput renders with a loading indicator 1`] = `

<span
aria-busy={true}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down Expand Up @@ -5900,7 +5874,6 @@ exports[`TextInput renders with a loading indicator 1`] = `

<span
aria-busy={true}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
size="large"
Expand Down Expand Up @@ -6158,7 +6131,6 @@ exports[`TextInput should render a password input 1`] = `

<span
aria-busy={false}
aria-live="polite"
className="c0 TextInput-wrapper"
onClick={[Function]}
>
Expand Down
2 changes: 2 additions & 0 deletions src/__tests__/deprecated/__snapshots__/ChoiceFieldset.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2203,6 +2203,7 @@ exports[`ChoiceFieldset renders with a success validation message 1`] = `
class="c11"
>
<span
aria-live="polite"
class="c12"
>
<span
Expand Down Expand Up @@ -2497,6 +2498,7 @@ exports[`ChoiceFieldset renders with an error validation message 1`] = `
class="c11"
>
<span
aria-live="polite"
class="c12"
>
<span
Expand Down