Skip to content

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Mar 30, 2023

This bumps @primer/primitives to

Screenshots

The snapshot diff is quite larger since the default text color changed. The most noticeable difference is the Primary button:

Before After
Screen Shot 2023-03-29 at 19 28 02 Screen Shot 2023-03-29 at 19 25 52

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2023

🦋 Changeset detected

Latest commit: 91dcc79

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 30, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 95.15 KB (-0.04% 🔽)
dist/browser.umd.js 95.72 KB (-0.03% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-3093 March 30, 2023 02:42 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3093 March 30, 2023 02:46 Inactive
@primer primer bot temporarily deployed to github-pages March 30, 2023 02:47 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3093 March 30, 2023 02:48 Inactive
```
npm run build
npm run test -- -u
```
@simurai simurai temporarily deployed to github-pages March 30, 2023 03:29 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3093 March 30, 2023 03:30 Inactive
```
npm test -- -u
```
@simurai simurai temporarily deployed to github-pages March 30, 2023 04:17 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3093 March 30, 2023 04:17 Inactive
@simurai simurai added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 30, 2023
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 30, 2023
@primer primer bot temporarily deployed to github-pages March 30, 2023 04:40 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3093 March 30, 2023 04:40 Inactive
@simurai simurai temporarily deployed to github-pages March 30, 2023 08:44 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3093 March 30, 2023 08:45 Inactive
@simurai simurai temporarily deployed to github-pages March 30, 2023 09:36 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3093 March 30, 2023 09:36 Inactive
@simurai simurai temporarily deployed to github-pages March 30, 2023 10:00 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3093 March 30, 2023 10:01 Inactive
@simurai simurai requested a review from lukasoppermann March 30, 2023 11:01
@simurai simurai marked this pull request as ready for review March 30, 2023 11:01
@simurai simurai requested review from a team and mperrotti March 30, 2023 11:01
@simurai simurai requested review from colebemis and joshblack April 3, 2023 01:51
@simurai simurai enabled auto-merge April 4, 2023 00:42
@simurai simurai disabled auto-merge April 4, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants