Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
9e5493e
Button with css
siddharthkp Mar 22, 2023
2df502e
Update generated/components.json
siddharthkp Mar 22, 2023
1224e8b
build with modules
siddharthkp Mar 22, 2023
c81d1c1
Merge branch 'spike-publish-css' of github.com:primer/react into spik…
siddharthkp Mar 22, 2023
7e9ff96
fix storybook setup
siddharthkp Mar 22, 2023
72ae002
auto import css from component
siddharthkp Mar 22, 2023
6e008b0
move patch package to build
siddharthkp Mar 23, 2023
ead3e2e
move back to postcss to create 1 file
siddharthkp Apr 12, 2023
a4f5d6f
wip
siddharthkp Apr 13, 2023
37b50e4
add another todo
siddharthkp Apr 17, 2023
bf00576
turns out we already use classnames
siddharthkp Apr 19, 2023
fd5151c
Merge branch 'main' into spike-publish-css
siddharthkp Apr 24, 2023
6752a47
Update generated/components.json
siddharthkp Apr 24, 2023
2e18e2d
test(vrt): update snapshots
siddharthkp Apr 24, 2023
cb1e02b
merge Button2 into drafts/Button2, delete drafts/IconButton
siddharthkp Apr 24, 2023
0b616b1
Merge branch 'spike-publish-css' of github.com:primer/react into spik…
siddharthkp Apr 24, 2023
114b350
Update generated/components.json
siddharthkp Apr 24, 2023
9c68346
Button.counter only accepts numbers
siddharthkp Apr 24, 2023
94d75cc
test(vrt): update snapshots
siddharthkp Apr 24, 2023
8834621
Add theming for primitives to BaseStyles
siddharthkp Apr 24, 2023
7d75f51
update checklist
siddharthkp Apr 24, 2023
3024134
Merge branch 'spike-publish-css' of github.com:primer/react into spik…
siddharthkp Apr 24, 2023
ea19c4d
test(vrt): update snapshots
siddharthkp Apr 24, 2023
29924ce
undo unrelated change
siddharthkp Apr 25, 2023
20ff4e5
Merge branch 'spike-publish-css' of github.com:primer/react into spik…
siddharthkp Apr 25, 2023
6f378ef
reduce unrelated changes
siddharthkp Apr 25, 2023
a3f2639
accidental delete
siddharthkp Apr 25, 2023
a95df78
remove task as done
siddharthkp Apr 25, 2023
97cc41e
Merge branch 'main' into spike-publish-css
siddharthkp Apr 25, 2023
2497640
update lockfile
siddharthkp Apr 25, 2023
6529201
reduce unrelated changes
siddharthkp Apr 25, 2023
7af5b4c
Update generated/components.json
siddharthkp Apr 25, 2023
359ab69
test(vrt): update snapshots
siddharthkp Apr 25, 2023
9d7e486
fix spacing for trailingAction
siddharthkp Apr 25, 2023
7ed9d3c
Merge branch 'spike-publish-css' of github.com:primer/react into spik…
siddharthkp Apr 25, 2023
d845859
maybe: increase specificity of sx
siddharthkp Apr 25, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions .storybook/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ module.exports = {
'@storybook/addon-interactions',
'@storybook/addon-a11y',
'@storybook/addon-links',
{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

css modules setup for storybook

name: 'storybook-css-modules',
options: {cssModulesLoaderOptions: {modules: {localIdentName: 'prc_[local]-[hash:base64:5]'}}},
},
{
name: 'storybook-addon-turbo-build',
options: {
Expand Down
3 changes: 3 additions & 0 deletions .storybook/preview.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
.storybook-debug {
outline: 2px solid tomato;
}
4 changes: 4 additions & 0 deletions .storybook/preview.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ import {addons} from '@storybook/addons'
import {withThemeProvider, withSurroundingElements, toolbarTypes} from '../src/utils/story-helpers'
import {PrimerBreakpoints} from '../src/utils/layout'

import '@primer/css/dist/primitives.css'
import '@primer/css/dist/color-modes.css'
Copy link
Member Author

@siddharthkp siddharthkp Apr 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: dependency on css variables from primitives!

import './preview.css'

export const globalTypes = toolbarTypes
export const decorators = [withThemeProvider, withSurroundingElements]

Expand Down
75 changes: 75 additions & 0 deletions generated/components.json
Original file line number Diff line number Diff line change
Expand Up @@ -4967,6 +4967,81 @@
}
]
},
"drafts_button": {
"id": "drafts_button",
"name": "Button",
"status": "draft",
"a11yReviewed": false,
"stories": [
{
"id": "components-button--default",
"code": "() => <Button>Default</Button>"
}
],
"props": [
{
"name": "children",
"required": true,
"type": "React.ReactNode",
"description": "The content of the button."
},
{
"name": "variant",
"type": "| 'default'\n| 'primary'\n| 'danger'\n| 'outline'\n| 'invisible'",
"defaultValue": "'default'",
"description": "Change the visual style of the button."
},
{
"name": "size",
"type": "| 'small'\n| 'medium'\n| 'large'",
"defaultValue": "'medium'"
},
{
"name": "leadingIcon",
"type": "React.ComponentType<OcticonProps>",
"description": "An icon to display before the button text."
},
{
"name": "trailingIcon",
"type": "React.ComponentType<OcticonProps>",
"description": "An icon to display after the button text."
},
{
"name": "as",
"type": "React.ElementType",
"defaultValue": "'button'"
},
{
"name": "sx",
"type": "SystemStyleObject"
},
{
"name": "ref",
"type": "React.RefObject<HTMLButtonElement>"
}
],
"passthrough": {
"element": "button",
"url": "https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#attributes"
},
"subcomponents": [
{
"name": "Button.Counter",
"props": [
{
"name": "children",
"required": true,
"type": "number",
"description": "The counter value."
},
{
"name": "sx",
"type": "SystemStyleObject"
}
]
}
]
},
"drafts_inline_autocomplete": {
"id": "drafts_inline_autocomplete",
"name": "InlineAutocomplete",
Expand Down
Loading