Skip to content

Enable direct-slot-children rule #3063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 22, 2023
Merged

Enable direct-slot-children rule #3063

merged 3 commits into from
Mar 22, 2023

Conversation

@colebemis
Copy link
Contributor

@colebemis colebemis commented Mar 22, 2023 •
edited
Loading

Enabled the direct-slot-children ESLint rule to catch future slot errors before we transition to the new SSR-friendly slots implementation.

@changeset-bot
Copy link

changeset-bot bot commented Mar 22, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 81d7bab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@colebemis colebemis added the skip changeset This change does not need a changelog label Mar 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 95.01 KB (0%)
dist/browser.umd.js 95.55 KB (0%)

@colebemis colebemis marked this pull request as ready for review March 22, 2023 18:56
@colebemis colebemis requested a review from a team March 22, 2023 18:56
@colebemis colebemis temporarily deployed to github-pages March 22, 2023 18:58 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3063 March 22, 2023 18:59 Inactive
@colebemis colebemis enabled auto-merge March 22, 2023 19:02
@colebemis colebemis added this pull request to the merge queue Mar 22, 2023
@colebemis colebemis merged commit 10408d8 into main Mar 22, 2023
@colebemis colebemis deleted the bump-eslint-2 branch March 22, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshblack joshblack joshblack approved these changes

@siddharthkp siddharthkp Awaiting requested review from siddharthkp

Assignees

No one assigned

Labels

skip changeset This change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@colebemis @joshblack