Skip to content

Conversation

@joshblack
Copy link
Member

Didn't realize this before committing 😅 The stories for DataTable currently use a relative time. As a result, each day the snapshots will be invalid. Removing these for now until the stories are refactored to use constant dates 👍

@joshblack joshblack requested review from a team and langermank March 21, 2023 15:49
@changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2023

⚠️ No Changeset found

Latest commit: 2be7406

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 95.03 KB (0%)
dist/browser.umd.js 95.57 KB (0%)

@joshblack joshblack temporarily deployed to github-pages March 21, 2023 15:56 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3058 March 21, 2023 15:56 Inactive
@joshblack joshblack added the skip changeset This change does not need a changelog label Mar 21, 2023
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to laugh but this is hilarious 😂

@joshblack joshblack added this pull request to the merge queue Mar 21, 2023
@joshblack joshblack merged commit 3022082 into main Mar 21, 2023
@joshblack joshblack deleted the test/remove-data-table-snapshots branch March 21, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants