Skip to content

Adds stories for the Pagination component #3037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 17, 2023
Merged

Adds stories for the Pagination component #3037

merged 6 commits into from
Mar 17, 2023

Conversation

@mperrotti
Copy link
Contributor

@mperrotti mperrotti commented Mar 15, 2023

While I was working on the Pagination component, I noticed it was missing from Storybook.

@mperrotti mperrotti requested review from a team and colebemis March 15, 2023 21:54
@changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: c94ff90

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mperrotti mperrotti added the skip changeset This change does not need a changelog label Mar 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 94.79 KB (0%)
dist/browser.umd.js 95.38 KB (0%)

@primer primer bot temporarily deployed to github-pages March 15, 2023 22:02 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3037 March 15, 2023 22:03 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3037 March 15, 2023 22:03 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3037 March 15, 2023 22:03 Inactive
colebemis
colebemis approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thank you, @mperrotti ❤️

Just left a minor comment about updating the storybook tests.

src/Pagination/Pagination.stories.tsx
import Pagination from './Pagination'

export default {
title: 'Components/Pagination',
Copy link
Contributor

@colebemis colebemis Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add "Pagination" to the component list in storybook.test.ts? https://github.com/primer/react/blob/main/src/__tests__/storybook.test.tsx

@mperrotti mperrotti added this pull request to the merge queue Mar 17, 2023
@mperrotti mperrotti merged commit c8522d3 into main Mar 17, 2023
@mperrotti mperrotti deleted the mp/add-pagination-stories branch March 17, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@colebemis colebemis colebemis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip changeset This change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mperrotti @colebemis