Skip to content

chore(project): add eslint plugin for playwright #3034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 21, 2023
Merged

chore(project): add eslint plugin for playwright #3034

merged 6 commits into from
Mar 21, 2023

Conversation

@joshblack
Copy link
Member

@joshblack joshblack commented Mar 15, 2023

@joshblack joshblack requested review from a team and broccolinisoup March 15, 2023 17:19
@changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 54d2927

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack added the skip changeset This change does not need a changelog label Mar 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 95.03 KB (0%)
dist/browser.umd.js 95.57 KB (0%)

@joshblack joshblack temporarily deployed to github-pages March 15, 2023 17:26 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3034 March 15, 2023 17:26 Inactive
@joshblack
Copy link
Member Author

joshblack commented Mar 20, 2023

bump @broccolinisoup when you have a sec to review!

@joshblack joshblack temporarily deployed to github-pages March 20, 2023 17:14 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3034 March 20, 2023 17:14 Inactive
broccolinisoup
broccolinisoup approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

@joshblack joshblack added this pull request to the merge queue Mar 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 21, 2023
@joshblack joshblack temporarily deployed to github-pages March 21, 2023 15:55 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3034 March 21, 2023 15:56 Inactive
@joshblack joshblack enabled auto-merge March 21, 2023 18:14
@joshblack joshblack temporarily deployed to github-pages March 21, 2023 18:20 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3034 March 21, 2023 18:20 Inactive
@joshblack joshblack added this pull request to the merge queue Mar 21, 2023
@joshblack joshblack merged commit e66cd99 into main Mar 21, 2023
@joshblack joshblack deleted the chore/add-eslint-plugin-playwright branch March 21, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@broccolinisoup broccolinisoup broccolinisoup approved these changes

Assignees

No one assigned

Labels

skip changeset This change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshblack @broccolinisoup