Skip to content

chore(DataTable): update ids for DataTable docs #3023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 14, 2023
Merged

chore(DataTable): update ids for DataTable docs #3023

merged 5 commits into from
Mar 14, 2023

Conversation

@joshblack
Copy link
Member

@joshblack joshblack commented Mar 13, 2023 •
edited
Loading

Changelog

New

Changed

  • Update DataTable.docs.json to include accurate ids and move to Components for primer.style IA
  • Update subcomponent names

Removed

@joshblack joshblack requested review from a team and broccolinisoup March 13, 2023 16:34
@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: aca78fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack requested a review from colebemis March 13, 2023 16:34
@joshblack joshblack added the skip changeset This change does not need a changelog label Mar 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 94.47 KB (0%)
dist/browser.umd.js 95.04 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-3023 March 13, 2023 16:40 Inactive
@joshblack joshblack added this pull request to the merge queue Mar 14, 2023
Merged via the queue into main with commit faa7667 Mar 14, 2023
@joshblack joshblack deleted the chore/update-story-ids-datatable branch March 14, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@broccolinisoup broccolinisoup Awaiting requested review from broccolinisoup

1 more reviewer

@colebemis colebemis colebemis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip changeset This change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshblack @colebemis