TreeView: Fix initial focus #2845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 645d0f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
colebemis
temporarily deployed
to
github-pages
GitHub Actions
Inactive
colebemis
commented
Feb 2, 2023
colebemis
temporarily deployed
to
github-pages
GitHub Actions
Inactive
colebemis
temporarily deployed
to
github-pages
GitHub Actions
Inactive
colebemis
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joshblack
approved these changes
Feb 6, 2023
colebemis
temporarily deployed
to
github-pages
GitHub Actions
Inactive
colebemis
temporarily deployed
to
github-pages
GitHub Actions
Inactive
colebemis
commented
Feb 8, 2023
| // | ||
| // WARNING: We don't recommend using TabNav inside an ActionMenu. | ||
| // This is a workaround to avoid breaking existing code. | ||
| focusInStrategy: isInsideMenu ? 'previous' : customStrategy, |
There was a problem hiding this comment.
Updating focusInStrategy to be compatiable with TreeView caused some TabNav tests to fail so I needed to the TabNav focusZone behavior. cc @joshblack since you were the last person to touch this code in #2468
This also fixes #2855
colebemis
temporarily deployed
to
github-pages
GitHub Actions
Inactive
colebemis
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joshblack
approved these changes
Feb 9, 2023
colebemis
temporarily deployed
to
github-pages
GitHub Actions
Inactive
colebemis
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defines a custom
focusInStrategyfor thefocusZonebehavior so the "current" treeitem is focused by default when a user focuses a TreeView.Storybook preview
Closes https://github.com/github/primer/issues/1750
Before
CleanShot.2023-01-31.at.13.54.32.mp4
After
CleanShot.2023-01-31.at.13.52.14.mp4