Skip to content

Conversation

@primer-css
Copy link
Contributor

@primer-css primer-css commented Jan 26, 2023

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@primer/[email protected]

Minor Changes

  • #2807 81447a10 Thanks @joshblack! - Add default type="button" for Button. This removes the implicit type="submit" for a <button> and requires an explicit type to change.

  • #2789 44f66cb9 Thanks @green6erry! - warn user if link as prop is not or

Patch Changes

@primer-css primer-css requested review from a team and josepmartins January 26, 2023 19:00
@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2023

❗ Pre-merge checklist

Please ensure these items are checked before merging.

🔎 Smoke test

  • All CI checks pass
  • Docs and Storybook open in a browser
  • Successful integration test with GitHub Projects as a primary consumer of Primer React https://github.com/github/memex/pull/14389
    • Install the Release Candidate
    • Verify no new build errors appear
    • Verify no new linting errors appear
    • Verify no new browser console errors appear
    • Verify unit tests and E2E tests pass
    • Manually test critical paths (Tip: Use the provided tests project boards)
    • Manually test release-specific bugfixes and/or features work as described
  • Works in CodeSandbox or StackBlitz
    • New components render successfully
    • (optional) Tested in both SPA and SSR apps if release contains build changes

🤔 Sanity test

  • All bugfixes in this release have resolved their corrosponding issues
  • All new features in this release have been tested and verified as compatible with GitHub Projects
  • No noticeable regressions have not been introduced as a result of changes in this release
  • Release notes accurately describe the changes made

🚢 After merge

  • Add the preview deployment's link to releases as a way of permalinking to old version's docs. Example

Please also leave any testing notes as a comment on this pull request. In particular, describing any issues encountered during your testing. This is helpful in providing historical context to maintainers.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 26, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 88.95 KB (0%)
dist/browser.umd.js 89.56 KB (0%)

@primer-css primer-css temporarily deployed to github-pages January 26, 2023 19:07 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2820 January 26, 2023 19:08 Inactive
@primer-css primer-css force-pushed the changeset-release/main branch from 3eec81a to d59661f Compare January 26, 2023 19:58
@primer-css primer-css temporarily deployed to github-pages January 26, 2023 20:05 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2820 January 26, 2023 20:06 Inactive
@primer-css primer-css force-pushed the changeset-release/main branch from d59661f to 3729897 Compare January 27, 2023 00:24
@primer-css primer-css temporarily deployed to github-pages January 27, 2023 00:29 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2820 January 27, 2023 00:30 Inactive
@primer-css primer-css force-pushed the changeset-release/main branch from 3729897 to 2e773e3 Compare January 27, 2023 17:52
@primer-css primer-css temporarily deployed to github-pages January 27, 2023 18:00 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2820 January 27, 2023 18:00 Inactive
@primer-css primer-css force-pushed the changeset-release/main branch from 2e773e3 to 289fc7a Compare January 27, 2023 19:43
@primer-css primer-css temporarily deployed to github-pages January 27, 2023 19:49 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2820 January 27, 2023 19:49 Inactive
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist confirmed ✅

@siddharthkp siddharthkp merged commit 98be95f into main Jan 30, 2023
@siddharthkp siddharthkp deleted the changeset-release/main branch January 30, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants