Skip to content

Improve initial useCombobox initialization process #2818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 26, 2023
Merged

Improve initial useCombobox initialization process #2818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2dabf7e
Improve initial combobox initialization process
iansan5653 Jan 26, 2023
90e031d
Create .changeset/olive-glasses-listen.md
iansan5653 Jan 26, 2023
2416c97
Merge branch 'main' into fix-suggestions
joshblack Jan 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/olive-glasses-listen.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Improve initial `useCombobox` initialization process to avoid race conditions
5 changes: 3 additions & 2 deletions src/drafts/hooks/useCombobox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ export const useCombobox = <T>({
if (!list.getAttribute('role')) list.setAttribute('role', 'listbox')

const cb = new Combobox(input, list, {tabInsertsSuggestions, defaultFirstOption})
if (isOpenRef.current) cb.start()

// By using state instead of a ref here, we trigger the toggleKeyboardEventHandling
// effect. Otherwise we'd have to depend on isOpen in this effect to start the instance
Expand All @@ -116,7 +115,9 @@ export const useCombobox = <T>({
useEffect(
function toggleKeyboardEventHandling() {
const wasOpen = isOpenRef.current
isOpenRef.current = isOpen

// It cannot be open if the instance hasn't yet been initialized
isOpenRef.current = isOpen && comboboxInstance !== null

if (isOpen === wasOpen || !comboboxInstance) return

Expand Down