1572 accessibility request primer react heading enforce what as can be set to with a runtime validation rule #2768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a844495 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
agreenberry
temporarily deployed
to
github-pages
GitHub Actions
Inactive
agreenberry
force-pushed
the
1572-accessibility-request-primer-react-heading-enforce-what-as-can-be-set-to-with-a-runtime-validation-rule
branch
from
860946a to
37ba4ef
Compare
…ing-enforce-what-as-can-be-set-to-with-a-runtime-validation-rule
Not needed
agreenberry
temporarily deployed
to
github-pages
GitHub Actions
Inactive
agreenberry
temporarily deployed
to
github-pages
GitHub Actions
Inactive
…ing-enforce-what-as-can-be-set-to-with-a-runtime-validation-rule
agreenberry
temporarily deployed
to
github-pages
GitHub Actions
Inactive
…ing-enforce-what-as-can-be-set-to-with-a-runtime-validation-rule
agreenberry
temporarily deployed
to
github-pages
GitHub Actions
Inactive
colebemis
approved these changes
Jan 27, 2023
…ing-enforce-what-as-can-be-set-to-with-a-runtime-validation-rule
agreenberry
temporarily deployed
to
github-pages
GitHub Actions
Inactive
agreenberry
deleted the
1572-accessibility-request-primer-react-heading-enforce-what-as-can-be-set-to-with-a-runtime-validation-rule
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes here.
Closes #1572
Screenshots
When implementing a
Headingcomponent without the relevant heading element type, like so......Then, the user sees as error in the code, as well as a log to warn the developer again:
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.