-
Notifications
You must be signed in to change notification settings - Fork 641
feat(TreeView): add support for empty parent nodes #2478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 19a9f0a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Could you add a couple of tests to make sure the aria-expanded attribute is behaving as expected in the sync and async cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this tricky implementation 💖
Should be ready to merge after fixing the lint error.
This PR updates
TreeView.ItemandTreeView.SubTreebased on the feedback over in: https://github.com/github/primer/pull/1389#discussion_r998754809Changelog
New
EmptyDirectorystory forTreeViewChanged
TreeView.ItemandTreeView.SubTreeto coordinate whether or notaria-expandedshould be set in sync and async contextsTreeView.Itemto announce when aTreeView.SubTreehas no content when used in an async contextTreeView.Itemto shift conditional rendering ofTreeView.SubTreeintoTreeView.SubTreeTreeView.test.tsxto removeit.onlyand replace timers withjest.useFakeTimersRemoved