[UnderlineNav2]: Add string type to the counter prop and display loading counter for all
#2449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6835a22 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
6 tasks
broccolinisoup
commented
Oct 18, 2022
| )} | ||
| {counter && ( | ||
| {loadingCounters ? ( | ||
| <Box as="span" data-component="counter" sx={counterStyles}> |
There was a problem hiding this comment.
Just wanted to point out that I am not super happy with this duplication of the the wrapper Box component but otherwise it wasn't easily readable so that was my trade off but open to suggestions (as always) 💖
|
@danielguillan Could I please get a review on loading counters? Especially for their width and background colour and opacity? Its source code is here Thank you! 😊 |
|
Thanks @broccolinisoup! Let's try the following:
|
broccolinisoup
force-pushed
the
underlineNav-sign-off-remediations
branch
2 times, most recently
from
74387fa to
4247884
Compare
broccolinisoup
force-pushed
the
loading-counters-fix
branch
from
d1c586e to
cc99b2f
Compare
Co-authored-by: Daniel Guillan <[email protected]>
danielguillan
approved these changes
Oct 21, 2022
broccolinisoup
added a commit
that referenced
this pull request
Oct 23, 2022
…ading counter for all (#2449) * string type for counters and fix loading issue * add changeset * improve docs * update animation details * Inverte the pulse effect Co-authored-by: Daniel Guillan <[email protected]> Co-authored-by: Daniel Guillan <[email protected]>
broccolinisoup
added a commit
that referenced
this pull request
Oct 24, 2022
…ading counter for all (#2449) * string type for counters and fix loading issue * add changeset * improve docs * update animation details * Inverte the pulse effect Co-authored-by: Daniel Guillan <[email protected]> Co-authored-by: Daniel Guillan <[email protected]>
broccolinisoup
added a commit
that referenced
this pull request
Oct 24, 2022
…ading counter for all (#2449) * string type for counters and fix loading issue * add changeset * improve docs * update animation details * Inverte the pulse effect Co-authored-by: Daniel Guillan <[email protected]> Co-authored-by: Daniel Guillan <[email protected]>
broccolinisoup
added a commit
that referenced
this pull request
Oct 25, 2022
…viour (A11y sign-off remediations) (#2447) * Discard the pointer types and scroll behaviour * add changeset * remove arrow btn styles * introduce gap between items and remove 4px padding around the links * [UnderlineNav2]: React router implementation fixes & docs improvement (#2448) * react router implementation fixes * add changeset * [UnderlineNav2]: Add string type to the `counter` prop and display loading counter for all (#2449) * string type for counters and fix loading issue * add changeset * improve docs * update animation details * Inverte the pulse effect Co-authored-by: Daniel Guillan <[email protected]> Co-authored-by: Daniel Guillan <[email protected]> * Remove unnecessary styles (scroll behaviour styles) * improve docs Co-authored-by: Daniel Guillan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed in this PR:
Storybook link: https://primer-8434fe8ecf-13348165.drafts.github.io/storybook/?path=/story/components-underlinenav--counters-loading-state
Documentation link: https://primer-8434fe8ecf-13348165.drafts.github.io/drafts/UnderlineNav2
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.