Skip to content

Conversation

@broccolinisoup
Copy link
Member

Just a few accessibility improvements while preparing UnderlineNav to accessibility review

  • Move More button into the ul to make it a sibling to other li elements.
  • Set arrow buttons' tabIndex to -1 when there are not visible.

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@broccolinisoup broccolinisoup requested review from a team and mperrotti September 28, 2022 08:36
@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2022

🦋 Changeset detected

Latest commit: 22d25d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/browser.esm.js 77.1 KB (0%)
dist/browser.umd.js 77.71 KB (0%)

@broccolinisoup broccolinisoup temporarily deployed to github-pages September 28, 2022 08:42 Inactive
@broccolinisoup
Copy link
Member Author

Closing this, as it is going to be handled in the another PR where it causes an issue.

@broccolinisoup broccolinisoup deleted the broccolinisoup/underlineNav-a11y branch September 30, 2022 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants