Skip to content

TreeView: Increase touch target size for coarse pointers #2376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 28, 2022
Merged

TreeView: Increase touch target size for coarse pointers #2376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
811bedf
Add type support for css customer properties in the sx prop
colebemis Sep 27, 2022
21d1056
Increase touch targets for coarse pointers
colebemis Sep 27, 2022
196e5e4
Create orange-beds-rhyme.md
colebemis Sep 27, 2022
151ce1a
Merge branch 'main' into treeview-coarse-pointer
colebemis Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/orange-beds-rhyme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

TreeView: Increase touch target size for coarse pointers
9 changes: 7 additions & 2 deletions src/TreeView/TreeView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,19 +169,24 @@ const Item: React.FC<TreeViewItemProps> = ({
}
}}
sx={{
'--toggle-width': '1rem', // 16px
position: 'relative',
display: 'grid',
gridTemplateColumns: `calc(${level - 1} * 8px) 16px 1fr`,
gridTemplateColumns: `calc(${level - 1} * (var(--toggle-width) / 2)) var(--toggle-width) 1fr`,
gridTemplateAreas: `"spacer toggle content"`,
width: '100%',
height: 32,
height: '2rem', // 32px
fontSize: 1,
color: 'fg.default',
borderRadius: 2,
cursor: 'pointer',
'&:hover': {
backgroundColor: 'actionListItem.default.hoverBg'
},
'@media (pointer: coarse)': {
'--toggle-width': '1.5rem', // 24px
Copy link
Member

@broccolinisoup broccolinisoup Sep 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Is there a specific value for min touch target size in the guideline? Because I increased the touch target size on the UnderlineNav as well but used the value from design. I am curious to see if there is a guideline

Copy link
Contributor Author

@colebemis colebemis Sep 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. @mperrotti might know!

height: '2.75rem' // 44px
},
// WARNING: styled-components v5.2 introduced a bug that changed
// how it expands `&` in CSS selectors. The following selectors
// are unnecessarily specific to work around that styled-components bug.
Expand Down
11 changes: 10 additions & 1 deletion src/sx.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,16 @@ export type BetterCssProperties = {
: SystemCssProperties[K]
}

export type BetterSystemStyleObject = BetterCssProperties | SystemStyleObject
// Support CSS custom properties in the `sx` prop
type CSSCustomProperties = {
[key: `--${string}`]: string | number
}

type CSSSelectorObject = {
[cssSelector: string]: SystemStyleObject | CSSCustomProperties
}

export type BetterSystemStyleObject = BetterCssProperties | SystemStyleObject | CSSCustomProperties | CSSSelectorObject

export interface SxProp {
sx?: BetterSystemStyleObject
Expand Down