Only run replaceChildren with htmlContainer change #2356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 35f5820 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
colebemis
approved these changes
Sep 21, 2022
Contributor
colebemis
left a comment
colebemis
left a comment
There was a problem hiding this comment.
Thanks, @nicolleromero!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstreams a fix applied in https://github.com/github/memex/pull/12104
Setting the dependency of
htmlContainerto the MarkdownVieweruseEffectpreventsreplaceChildrenfrom running unnecessarily (prevents removing and then immediately adding the element and triggering a bug in the selector-observer library).Screenshots
See referenced PR for screenshots
Merge checklist
[ ] Added/updated tests[ ] Added/updated documentation[ ] Tested in Edge