-
Notifications
You must be signed in to change notification settings - Fork 645
TreeView: Add nesting indicator lines #2350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
91203b8
Add TreeView docs
colebemis d425776
Update TreeView props
colebemis 6523985
Scaffold treeview markup
colebemis 30bbae4
Add TreeView to drafts
colebemis 15dc5b2
Add comment
colebemis 46fd1d5
Track item levels
colebemis a980f76
Add TreeView stories
colebemis 9961985
Update TreeView docs
colebemis 945c58c
Update TreeView markup
colebemis 5b03f71
Create curly-birds-argue.md
colebemis 4072099
Merge branch 'main' into treeview-markup
colebemis 109f05e
Fix examples
colebemis 49303b0
Update src/TreeView/TreeView.tsx
colebemis cbebf14
Update docs/content/TreeView.mdx
colebemis b3a3096
Add some tests
colebemis 2b666bd
Implement arrow key navigation
colebemis df5444b
Fix arrow left
colebemis ba2166a
Set up aria-activedescendant
colebemis 3437e11
Display focus ring on active descendant
colebemis d6002e3
Use arrow key to change active descendant
colebemis 769715b
Handle expand/collapse with arrow keys
colebemis c4bc882
Merge branch 'main' into treeview-arrow-keys
colebemis bbec34b
Fix lint error
colebemis e22679d
Add up and down arrow key test
colebemis dbece82
Prevent default when moving focus with arrow keys
colebemis 2f58284
Open links in same tab by default
colebemis 2ad9f73
Add test for right arrow key expand
colebemis 0065cfa
Add defaultExpanded prop
colebemis d41f319
Test left arrow key collapse
colebemis 515a9fc
Reorganize tests
colebemis f99388b
Create neat-squids-cheat.md
colebemis b165dcf
Add more tests
colebemis 96ac6d8
Implement home and end key behavior
colebemis 311c27f
Merge branch 'treeview-arrow-keys' of github.com:primer/react into tr…
colebemis 1325ca4
Update active descendant on click
colebemis c0c1745
Remove focus state
colebemis 8303416
Remove focus state from context
colebemis 9106046
Test enter and space keys
colebemis 847053d
Update focus style
colebemis e949bc6
Merge branch 'main' into treeview-arrow-keys
colebemis 79d0ccc
Remove Space key behavior
colebemis e1dcac4
Merge branch 'treeview-arrow-keys' of github.com:primer/react into tr…
colebemis d1f2945
Wrap test cases with themeprovider
colebemis 13473b2
Add test for link item
colebemis b9b4415
Update urls
colebemis 92d746a
Add indicator lines for each nested level
colebemis c8a8017
Create heavy-pets-own.md
colebemis c6469db
Merge branch 'main' into treeview-nested-lines
colebemis 7881022
Create LevelIndicatorLines component
colebemis 830d6db
Merge branch 'treeview-nested-lines' of github.com:primer/react into …
colebemis a0425a4
Merge branch 'main' into treeview-nested-lines
colebemis 003153f
Remove transitions for now
colebemis 61a2d83
Merge branch 'main' into treeview-nested-lines
colebemis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@primer/react": patch | ||
| --- | ||
|
|
||
| Adds lines to indicate the depth of items in a TreeView |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️