Skip to content

Change createSlots to use layout effects when registering slots #2216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 5, 2022
Merged

Change createSlots to use layout effects when registering slots #2216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b0fff59
Change createSlots to use layout effects instead of regular effects
iansan5653 Jul 27, 2022
e8bccbc
Update snapshots
iansan5653 Aug 4, 2022
28a2276
Create hip-buses-eat.md
iansan5653 Aug 4, 2022
b5dbe13
Merge branch 'main' into slots-layout-effect
iansan5653 Aug 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hip-buses-eat.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Change `createSlots` to use layout effects when registering slots
102 changes: 84 additions & 18 deletions src/__tests__/__snapshots__/CheckboxGroup.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,46 @@ exports[`CheckboxGroup renders consistently 1`] = `
padding: 0;
}

.c3 {
.c4 {
display: -webkit-box;
display: -webkit-flex;
display: -ms-flexbox;
display: flex;
}

.c4 > input {
.c5 > input {
margin-left: 0;
margin-right: 0;
}

.c7 {
margin-left: 8px;
display: -webkit-box;
display: -webkit-flex;
display: -ms-flexbox;
display: flex;
-webkit-flex-direction: column;
-ms-flex-direction: column;
flex-direction: column;
}

.c2 {
display: block;
font-size: 16px;
}

.c8 {
font-weight: 600;
font-size: 14px;
display: block;
color: #24292f;
cursor: pointer;
-webkit-align-self: flex-start;
-ms-flex-item-align: start;
align-self: flex-start;
}

.c3 {
display: -webkit-box;
display: -webkit-flex;
display: -ms-flexbox;
Expand All @@ -37,25 +64,25 @@ exports[`CheckboxGroup renders consistently 1`] = `
padding: 0;
}

.c2 > * + * {
.c3 > * + * {
margin-top: 8px;
}

.c5 {
.c6 {
cursor: pointer;
}

.c5:focus:not(:disabled) {
.c6:focus:not(:disabled) {
box-shadow: none;
outline: 2px solid #0969da;
outline-offset: 0;
}

.c5:focus:not(:disabled):not(:focus-visible) {
.c6:focus:not(:disabled):not(:focus-visible) {
outline: solid 1px transparent;
}

.c5:focus-visible:not(:disabled) {
.c6:focus-visible:not(:disabled) {
box-shadow: none;
outline: 2px solid #0969da;
outline-offset: 0;
Expand All @@ -68,72 +95,111 @@ exports[`CheckboxGroup renders consistently 1`] = `
>
<legend
className="c1"
/>
>
<span
className="c2"
>
Choices
</span>
</legend>
<div
className="c2"
className="c3"
>
<div
className="c3"
className="c4"
display="flex"
>
<div
className="c4"
className="c5"
>
<input
aria-checked="false"
aria-disabled="false"
aria-invalid="false"
aria-required="false"
className="c5"
className="c6"
id="react-aria-2"
name="one"
onChange={[Function]}
type="checkbox"
value="one"
/>
</div>
<div
className="c7"
display="flex"
>
<label
className="c8"
htmlFor="react-aria-2"
>
Choice one
</label>
</div>
</div>
<div
className="c3"
className="c4"
display="flex"
>
<div
className="c4"
className="c5"
>
<input
aria-checked="false"
aria-disabled="false"
aria-invalid="false"
aria-required="false"
className="c5"
className="c6"
id="react-aria-3"
name="two"
onChange={[Function]}
type="checkbox"
value="two"
/>
</div>
<div
className="c7"
display="flex"
>
<label
className="c8"
htmlFor="react-aria-3"
>
Choice two
</label>
</div>
</div>
<div
className="c3"
className="c4"
display="flex"
>
<div
className="c4"
className="c5"
>
<input
aria-checked="false"
aria-disabled="false"
aria-invalid="false"
aria-required="false"
className="c5"
className="c6"
id="react-aria-4"
name="three"
onChange={[Function]}
type="checkbox"
value="three"
/>
</div>
<div
className="c7"
display="flex"
>
<label
className="c8"
htmlFor="react-aria-4"
>
Choice three
</label>
</div>
</div>
</div>
</fieldset>
Expand Down
Loading