Skip to content

Conversation

@rezrah
Copy link
Contributor

@rezrah rezrah commented Apr 20, 2022

What are you trying to accomplish?

Removes postinstall scripts introduced in #2028 , which could break the consumer released package when installed

What approach did you choose and why?

Removed recently added postinstall and added the same logic to the workflows that need it.

What should reviewers focus on?

  • Package should be tested to make sure it installs successfully.

@rezrah rezrah added the skip changeset This change does not need a changelog label Apr 20, 2022
@rezrah rezrah requested review from a team and colebemis April 20, 2022 18:20
@changeset-bot
Copy link

changeset-bot bot commented Apr 20, 2022

⚠️ No Changeset found

Latest commit: 8a49387

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/browser.esm.js 65.55 KB (0%)
dist/browser.umd.js 65.9 KB (0%)

@rezrah rezrah temporarily deployed to github-pages April 20, 2022 18:38 Inactive
@rezrah rezrah merged commit 4fd9b74 into main Apr 20, 2022
@rezrah rezrah deleted the rezrah/fix-postinstall branch April 20, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants