Skip to content

Conversation

@mperrotti
Copy link
Contributor

Screenshots

  1. Fix a spacing issue with the loading spinner in a TextInputWithTokens

Before:
Screen Shot 2022-04-07 at 10 58 58 AM

After:
Screen Shot 2022-04-07 at 10 58 45 AM

  1. Bolds form validation text to be visually balanced with the icon

Before:
Screen Shot 2022-04-07 at 10 57 45 AM

After:
Screen Shot 2022-04-07 at 10 57 00 AM

Merge checklist

  • Added/updated tests
  • [n/a] Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@mperrotti mperrotti requested review from a team and colebemis April 7, 2022 18:03
@changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2022

🦋 Changeset detected

Latest commit: 17b44bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 65.55 KB (+0.02% 🔺)
dist/browser.umd.js 65.9 KB (+0.02% 🔺)

@mperrotti mperrotti temporarily deployed to needs-approval April 7, 2022 18:07 Inactive
@mperrotti mperrotti temporarily deployed to needs-approval April 8, 2022 18:30 Inactive
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@mperrotti mperrotti temporarily deployed to needs-approval April 13, 2022 14:52 Inactive
@mperrotti mperrotti temporarily deployed to needs-approval April 13, 2022 18:13 Inactive
@mperrotti mperrotti temporarily deployed to needs-approval April 19, 2022 13:52 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants