Fix code example renders #1969
Merged
Fix code example renders #1969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
size-limit report 📦
|
colebemis
approved these changes
Mar 16, 2022
Contributor
colebemis
left a comment
colebemis
left a comment
There was a problem hiding this comment.
Thank you for fixing this!
colebemis
reviewed
Mar 16, 2022
colebemis
approved these changes
Mar 16, 2022
pksjce
pushed a commit
that referenced
this pull request
Mar 17, 2022
* removes deprecated Octicons export from docs scope * undo the change of order in exports * adds comment about why we do not export octicons-react default export * Update docs/src/@primer/gatsby-theme-doctocat/live-code-scope.js * Update export Co-authored-by: Cole Bemis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were exporting octicons' deprecated
defaultexport.