Skip to content

Conversation

@colebemis
Copy link
Contributor

@colebemis colebemis commented Feb 28, 2022

Motivation

We want to reduce the frequency of major releases of @primer/react without slowing down the release cadence of minor and patch releases.

Solution

This PR implements workflow changes that allow us to merge breaking changes into a next-major branch (instead of main) that can be tracked and released independently of minor and patch versions.

image

@changeset-bot
Copy link

changeset-bot bot commented Feb 28, 2022

⚠️ No Changeset found

Latest commit: 7bd0f95

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 64.24 KB (0%)
dist/browser.umd.js 64.6 KB (0%)

@jonrohan
Copy link
Member

If this nice workflow diagram is intended to stay in docs somewhere, there's one small update to this block
image

Create branch called 'next-major' from 'main' branch

Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this has generally worked for us in primer/css. 👍🏻

Comment on lines 6 to +7
- 'changeset-release/main'
- 'changeset-release/next-major'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 'changeset-release/main'
- 'changeset-release/next-major'
- 'changeset-release/**'

Not necessary but these could be **

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to be explicit here because I'm referencing those branch names directly in the workflow if statements

@colebemis colebemis merged commit 851085d into main Feb 28, 2022
@colebemis colebemis deleted the next-major-workflow branch February 28, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants