Deprecate ChoiceFieldset and ChoiceInputField #1891
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ab34fd4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
This is dependent on #1862 merging |
#1862) * adds ChoiceGroup components and Storybook stories * removes unnecessary code from ChoiceGroup * adds tests and fixes issues discovered during testing * adds sx prop and standard component tests * converts stories to fixtures and examples, adds axe violation tests * marks ChoiceFieldset as deprecated * adds ChoiceGroup docs * updates snapshots * adds changeset * fixes tests I accidentally broke * addresses PR feedback * cleanup * WIP - splitting CheckboxGroup and RadioGroup * cleans up, adds RadioGroup component * adds stories for CheckboxGroup and RadioGroup * adds and updates tests * ts fixes, rm ChoiceGroup stories * renames ChoiceGroup to CheckboxOrRadioGroup * updates docs, handles pre-selected radios and/or checkboxes * updates snapshots * cleans up, fixes broken tests
mperrotti
force-pushed
the
mp/deprecate-choicefieldset+choiceinputfield
branch
from
82d14c8 to
4cc19c0
Compare
mperrotti
force-pushed
the
mp/deprecate-choicefieldset+choiceinputfield
branch
from
4cc19c0 to
82e4060
Compare
* prepare integration branch * Move deprecated components to deprecated folder * Add subpath exports for deprecated * Fix up the docs * Remove dialog and formgroup components * Fix up all the tests * Create smooth-cameras-prove.md Co-authored-by: Reza Rahman <[email protected]>
…#1883) * prefix component name to types * add changeset * Update .changeset/actionlist2-actionmenu2-prefix-types.md Co-authored-by: Cole Bemis <[email protected]> Co-authored-by: Cole Bemis <[email protected]>
* Export PageLayout from main bundle * Create odd-apes-guess.md * Add PageLayout to sidenav * Update .changeset/odd-apes-guess.md Co-authored-by: Rez <[email protected]> * Update PageLayout docs Co-authored-by: Rez <[email protected]>
…ropdown (#1887) * chore: add deprecation notices for SelectMenu and Dropdown * fix: deprecated metadata scope in docs * docs: update release notes for Flex and BorderBox * docs: update release notes for Position * chore: add deprecated scope to jsx snippets * chore: add release notes for Dropdown deprecation * chore: add Grid release notes * update release notes
* Deprecate ActionList v1 * Promote drafts/ActionList2 to main/ActionList * Add changelog * Undo package-lock change * update ActionList import for Menu2 docs * Deprecate ActionMenu - part 1 * Deprecate ActionMenu - part 2 * Promote drafts/ActionMenu2 to main/ActionMenu * Add changelog * Add @deprecated on deprecated/ActionMenu * docs fixed!
* Deprecate ActionList v1 * Promote drafts/ActionList2 to main/ActionList * Add changelog * Undo package-lock change * update ActionList import for Menu2 docs * changelog oopsie * fix docs copy * Add @deprecated on deprecated/ActionList * oopsie on the link * PR feedback on deprecation message
* prepare integration branch * Move deprecated components to deprecated folder * Add subpath exports for deprecated * Fix up the docs * Remove dialog and formgroup components * Fix up all the tests * Create smooth-cameras-prove.md Co-authored-by: Reza Rahman <[email protected]>
mperrotti
force-pushed
the
mp/deprecate-choicefieldset+choiceinputfield
branch
from
82e4060 to
ab34fd4
Compare
Contributor
Author
|
This PR has gotten out of hand. I'm just opening a new one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.