Skip to content

Update label componentId #1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2022
Merged

Update label componentId #1787

merged 1 commit into from
Jan 11, 2022

Conversation

@colebemis
Copy link
Contributor

@colebemis colebemis commented Jan 11, 2022

The React Label component wasn't being displayed correctly on the primer.style/status page because the componentId in our docs was label_group instead of label.

@colebemis colebemis requested review from a team and mperrotti January 11, 2022 20:28
@colebemis colebemis temporarily deployed to visual-testing January 11, 2022 20:28 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Jan 11, 2022

⚠️ No Changeset found

Latest commit: 9327daa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@colebemis colebemis added the skip changeset This change does not need a changelog label Jan 11, 2022
@colebemis colebemis merged commit 2d5f64e into main Jan 11, 2022
@colebemis colebemis deleted the colebemis-patch-2 branch January 11, 2022 20:30
@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 61.25 KB (0%)
dist/browser.umd.js 61.63 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mperrotti mperrotti mperrotti approved these changes

Assignees

No one assigned

Labels

skip changeset This change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@colebemis @mperrotti