Remove "engines" field from package.json #1712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2da1e52 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
jfuchs
reviewed
Dec 9, 2021
Contributor
jfuchs
left a comment
jfuchs
left a comment
There was a problem hiding this comment.
Is engines supposed to be about what's needed to run the distributed package? Or is it about what's needed to build and contribute?
Contributor
Author
|
I think it's "what's needed to run the distributed package" because I couldn't install |
Contributor
Author
|
https://docs.npmjs.com/cli/v6/configuring-npm/package-json#engines
|
jfuchs
approved these changes
Dec 9, 2021
Merged
pksjce
pushed a commit
that referenced
this pull request
Dec 20, 2021
* Remove "engines" field from package.json * Create tidy-maps-care.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
enginesfield is breaking builds for projects using node <16. Since node 16 is not required to use@primer/react, let's remove this field from the package.json.