Skip to content

ActionList: test stories for axe violations #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 29, 2021
Merged

ActionList: test stories for axe violations #1602

merged 6 commits into from
Nov 29, 2021

Conversation

@siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Nov 11, 2021 •
edited
Loading

Added a util to test stories for axe violations. This should help us test easy to catch violations. The fix could be in the component or in the story.

Expecting build to fail, issues found here fixed by multiple PRs:

Update: Build passes now!

@siddharthkp siddharthkp requested review from a team and rezrah November 11, 2021 16:07
@changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6641669

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siddharthkp siddharthkp mentioned this pull request Nov 11, 2021
Closed
@siddharthkp siddharthkp marked this pull request as draft November 11, 2021 16:09
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2021 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 57.31 KB (0%)
dist/browser.umd.js 57.72 KB (0%)

@siddharthkp siddharthkp self-assigned this Nov 11, 2021
@siddharthkp siddharthkp added the skip changeset This change does not need a changelog label Nov 12, 2021
@siddharthkp siddharthkp marked this pull request as ready for review November 24, 2021 15:42
colebemis
colebemis approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the idea of using component stories in our tests ❤️

@siddharthkp siddharthkp merged commit 40eaa59 into main Nov 29, 2021
@siddharthkp siddharthkp deleted the siddharth/actionlist-axe branch November 29, 2021 10:21
pksjce pushed a commit that referenced this pull request Dec 20, 2021
@siddharthkp @pksjce
ActionList: test stories for axe violations (#1602)
0ba1cf3 
* add all ActionList stories to tests

* remove over eager aria-multiselectable

* Add semantic roles to ActionList stories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rezrah rezrah Awaiting requested review from rezrah

1 more reviewer

@colebemis colebemis colebemis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@siddharthkp siddharthkp

Labels

accessibility react skip changeset This change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@siddharthkp @colebemis