fix(useFocusZone): handle add/remove nodes that have focusable children #1185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within a focus zone, we watch for child nodes to be added/removed. Currently, we only do something with those changes if the node that was changed
isFocusable, or has been registered as a focus target. If that condition is met, we search all children of the changed node to find focus targets. This setup does not account for scenarios when the added/removed node is not itself focusable, but it does have children that are focusable. This change removes the top-level check and simply always searches for focusable children. This is a noticeable issue inSelectPanel, where the list items are added/removed frequently with changes to the filter.Merge checklist