Skip to content

DropdownMenu #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 56 commits into from
Apr 16, 2021
Merged

DropdownMenu #1135

merged 56 commits into from
Apr 16, 2021

Conversation

@smockle
Copy link
Member

@smockle smockle commented Mar 25, 2021 •
edited
Loading

This is a working branch composed of main, overlay and action-list.

Fixes #1070

Preview

dropdown

@changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 20ebbe1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 25, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/9PHTXPcXpPxj7rm3NEkWYtm7DX6j
✅ Preview: https://primer-components-git-dropdownmenu-primer.vercel.app

@smockle smockle mentioned this pull request Apr 5, 2021
Merged
7 tasks
@vercel vercel bot temporarily deployed to Preview April 7, 2021 15:56 Inactive
@vercel vercel bot temporarily deployed to Preview April 7, 2021 16:15 Inactive
@vercel vercel bot temporarily deployed to Preview April 7, 2021 19:38 Inactive
@dgreif dgreif mentioned this pull request Apr 9, 2021
Merged
6 tasks
@vercel vercel bot temporarily deployed to Preview April 12, 2021 17:50 Inactive
@vercel vercel bot temporarily deployed to Preview April 12, 2021 21:55 Inactive
@smockle
fix: Rename focus-related state and values to distinguish/dedupe from…
0029c37 
… the Overlay open(rendered)/closed(not-rendered) state.
@vercel vercel bot temporarily deployed to Preview April 13, 2021 16:06 Inactive
@vercel vercel bot temporarily deployed to Preview April 13, 2021 16:11 Inactive
@vercel vercel bot temporarily deployed to Preview April 13, 2021 16:14 Inactive
@vercel vercel bot temporarily deployed to Preview April 16, 2021 17:28 Inactive
colebemis
colebemis reviewed Apr 16, 2021
View reviewed changes
@vercel vercel bot temporarily deployed to Preview April 16, 2021 17:32 Inactive
colebemis
colebemis reviewed Apr 16, 2021
View reviewed changes
colebemis
colebemis reviewed Apr 16, 2021
View reviewed changes
colebemis
colebemis reviewed Apr 16, 2021
View reviewed changes
@vercel vercel bot temporarily deployed to Preview April 16, 2021 17:40 Inactive
@vercel vercel bot temporarily deployed to Preview April 16, 2021 17:44 Inactive
@vercel vercel bot temporarily deployed to Preview April 16, 2021 17:51 Inactive
@vercel vercel bot temporarily deployed to Preview April 16, 2021 18:32 Inactive
@vercel vercel bot temporarily deployed to Preview April 16, 2021 18:54 Inactive
@dgreif dgreif mentioned this pull request Apr 16, 2021
Merged
T-Hugs
T-Hugs approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@T-Hugs T-Hugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 💯 🚀 🎸

colebemis
colebemis approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🚢

@dgreif dgreif enabled auto-merge (squash) April 16, 2021 19:24
@vercel vercel bot temporarily deployed to Preview April 16, 2021 19:24 Inactive
@vercel vercel bot temporarily deployed to Preview April 16, 2021 19:34 Inactive
@dgreif dgreif merged commit dfb8039 into main Apr 16, 2021
@dgreif dgreif deleted the dropdownmenu branch April 16, 2021 19:37
@smockle smockle mentioned this pull request Jun 11, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgreif dgreif dgreif left review comments

+3 more reviewers

@VanAnderson VanAnderson VanAnderson left review comments

@T-Hugs T-Hugs T-Hugs approved these changes

@colebemis colebemis colebemis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DropdownMenu

6 participants

@smockle @T-Hugs @dgreif @colebemis @VanAnderson